Switch ubuntu-codename to distro-codename and new docker_build_deb.py script #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbeaudoin0935
requested review from
bjordiscollaku and
vishwasudupa
as code owners
simonbeaudoin0935
force-pushed
the
development
branch
2 times, most recently
from
cab1d22 to
491ed45
Compare
simonbeaudoin0935
changed the title
simonbeaudoin0935
changed the title
Builds arm64 packages nativaly on arm64, or cross compiles on amd64
- Choice of ditribution codename between 'noble' and 'questing' since
those are the two chroots initially created in the Dockerfile.{arch}.
- Verify Docker CLI/daemon and socket permissions with actionable errors.
- Ensure builder image (qualcomm-linux/pkg-build:{arch}-latest); build from ../docker/Dockerfile.{arch} if missing.
- Run gbp buildpackage inside the container (mounts src/output, preserves uid:gid, sets git safe.directory).
- Stream build output live; create output dir and print last 500 lines of .build on failure.
Signed-off-by: Simon Beaudoin <[email protected]>
Signed-off-by: Simon Beaudoin <[email protected]>
simonbeaudoin0935
force-pushed
the
development
branch
from
491ed45 to
589b526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the input parameter ubuntu-codename to distro-codename to better align with what it represents.
The sbuild --distro parameter is what this input represents, so having distro- in the name is better.
docker_build_deb.py :