Undo last commit

Author: MarcoBarroca

qiskit_nature/second_q/operators/bosonic_op.py

@@ -214,8 +214,7 @@ def _validate_keys(self, keys: Collection[str]) -> None:
             for term in key.split():
                 index = int(term[2:])
                 if num_so is None:
-                    if index > max_index:
-                        max_index = index
+                    max_index = max(max_index, index)
                 elif index >= num_so:
                     raise QiskitNatureError(
                         f"The index, {index}, from the label, {key}, exceeds the number of spin "

qiskit_nature/second_q/operators/fermionic_op.py

@@ -216,8 +216,7 @@ def _validate_keys(self, keys: Collection[str]) -> None:
             for term in key.split():
                 index = int(term[2:])
                 if num_so is None:
-                    if index > max_index:
-                        max_index = index
+                    max_index = max(max_index, index)
                 elif index >= num_so:
                     raise QiskitNatureError(
                         f"The index, {index}, from the label, {key}, exceeds the number of spin "

qiskit_nature/second_q/operators/spin_op.py

@@ -275,8 +275,7 @@ def _validate_keys(self, keys: Collection[str]) -> None:
                 # sub_terms[0] is the base, sub_terms[1] is the (optional) exponent
                 index = int(sub_terms[0][2:])
                 if num_s is None:
-                    if index > max_index:
-                        max_index = index
+                    max_index = max(max_index, index)
                 elif index >= num_s:
                     raise QiskitNatureError(
                         f"The index, {index}, from the label, {key}, exceeds the number of "

qiskit_nature/second_q/problems/properties_container.py

@@ -80,8 +80,7 @@ def __len__(self) -> int:
         return len(self._properties)
 
     def __iter__(self) -> Generator[SparseLabelOpsFactory, None, None]:
-        for prop in self._properties.values():
-            yield prop
+        yield from self._properties.values()
 
     def _getter(self, _type: type) -> SparseLabelOpsFactory | None:
         """An internal utility method to handle the attribute getter implementation.