Skip to content

Conversation

@CarlJi
Copy link
Collaborator

@CarlJi CarlJi commented Jun 23, 2022

No description provided.

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #285 (84ced08) into master (522c284) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   71.05%   70.95%   -0.10%     
==========================================
  Files          34       34              
  Lines        2011     2011              
==========================================
- Hits         1429     1427       -2     
- Misses        472      473       +1     
- Partials      110      111       +1     
Flag Coverage Δ
e2e-1.16.x ?
e2e-1.17.x ?
e2e-1.18.x ?
unittest-1.16.x 70.86% <100.00%> (-0.10%) ⬇️
unittest-1.17.x 70.86% <100.00%> (-0.10%) ⬇️
unittest-1.18.x 70.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/profile.go 25.00% <100.00%> (ø)
pkg/build/legacy.go 95.12% <0.00%> (-4.88%) ⬇️

@CarlJi CarlJi merged commit b4f0c87 into qiniu:master Jun 23, 2022
@CarlJi CarlJi deleted the goc_profile_force branch June 23, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants