Skip to content

Commit d7e23fb

Browse files
committed
Revert "[config reload] Fixing config reload when timer based delayed services are disabled (sonic-net#1967)"
This reverts commit 055ed4f.
1 parent fa23bfc commit d7e23fb

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

config/main.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -732,15 +732,8 @@ def _get_sonic_services():
732732

733733

734734
def _get_delayed_sonic_services():
735-
rc1 = clicommon.run_command("systemctl list-dependencies --plain sonic-delayed.target | sed '1d'", return_cmd=True)
736-
rc2 = clicommon.run_command("systemctl is-enabled {}".format(rc1.replace("\n", " ")), return_cmd=True)
737-
timer = [line.strip() for line in rc1.splitlines()]
738-
state = [line.strip() for line in rc2.splitlines()]
739-
services = []
740-
for unit in timer:
741-
if state[timer.index(unit)] == "enabled":
742-
services.append(unit.rstrip(".timer"))
743-
return services
735+
out = clicommon.run_command("systemctl list-dependencies --plain sonic-delayed.target | sed '1d'", return_cmd=True)
736+
return (unit.strip().rstrip('.timer') for unit in out.splitlines())
744737

745738

746739
def _reset_failed_services():

tests/config_test.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ def mock_run_command_side_effect(*args, **kwargs):
8484
return 'snmp.timer'
8585
elif command == "systemctl list-dependencies --plain sonic.target | sed '1d'":
8686
return 'swss'
87-
elif command == "systemctl is-enabled snmp.timer":
88-
return 'enabled'
8987
else:
9088
return ''
9189

@@ -166,7 +164,7 @@ def test_load_minigraph(self, get_cmd_module, setup_single_broadcom_asic):
166164
mock_run_command.assert_any_call('systemctl reset-failed swss')
167165
# Verify "systemctl reset-failed" is called for services under sonic-delayed.target
168166
mock_run_command.assert_any_call('systemctl reset-failed snmp')
169-
assert mock_run_command.call_count == 11
167+
assert mock_run_command.call_count == 10
170168

171169
def test_load_minigraph_with_port_config_bad_format(self, get_cmd_module, setup_single_broadcom_asic):
172170
with mock.patch(

0 commit comments

Comments
 (0)