Skip to content

Commit 2de3a8e

Browse files
authored
Fixed weight bug; Corrected associated unit test (#52)
1 parent f5ce98d commit 2de3a8e

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/pyiges/geometry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ def _add_parameters(self, parameters):
277277

278278
# Weights
279279
self.W = []
280-
for i in range(self.A + 8, self.A + self.K + 8):
280+
for i in range(self.A + 8, self.A + self.K + 8 + 1):
281281
self.W.append(parse_float(parameters[i]))
282282

283283
# Control points
@@ -321,7 +321,7 @@ def to_geomdl(self):
321321
curve = NURBS.Curve()
322322
curve.degree = self.M
323323
curve.ctrlpts = self.control_points
324-
curve.weights = self.W + [1]
324+
curve.weights = self.W
325325
curve.knotvector = self.T # Set knot vector
326326
return curve
327327

tests/test_pyiges.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ def test_bsplines_parse(curve):
309309
)
310310

311311
assert curve.W == pytest.approx(
312-
[1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0]
312+
[1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0]
313313
)
314314

315315
assert curve.d == {

0 commit comments

Comments
 (0)