-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Update mnist.py - change the order of mirror links #8865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mnist.py - change the order of mirror links #8865
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8865
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @naman1303! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Anyone looking at this PR? |
NicolasHug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @naman1303 .
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: scotts Differential Revision: D77997064 fbshipit-source-id: 7141bd84315f71fcb2da4326da6b36a8abfcabb0
Upgrade torch from 2.5.0 to 2.7.0 and torchvision from 0.20.0 to 0.22.0 to fix MNIST dataset download failure caused by unreliable yann.lecun.com server returning HTTP 404 errors. The fix was merged in pytorch/vision#8865 which reorders the mirror list to prioritize the reliable AWS S3 mirror over yann.lecun.com. Related issues: - pytorch/vision#8568 - pytorch/vision#8865 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Meng Yan <[email protected]>
Upgrade torch from 2.5.0 to 2.9.0 and torchvision from 0.20.0 to 0.24.0 to fix MNIST dataset download failure caused by unreliable yann.lecun.com server returning HTTP 404 errors. The fix was merged in pytorch/vision#8865 which reorders the mirror list to prioritize the reliable AWS S3 mirror over yann.lecun.com. Related issues: - pytorch/vision#8568 - pytorch/vision#8865 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Meng Yan <[email protected]>
Upgrade torch from 2.5.0 to 2.9.0 and torchvision from 0.20.0 to 0.24.0 to fix MNIST dataset download failure caused by unreliable yann.lecun.com server returning HTTP 404 errors. The fix was merged in pytorch/vision#8865 which reorders the mirror list to prioritize the reliable AWS S3 mirror over yann.lecun.com. Related issues: - pytorch/vision#8568 - pytorch/vision#8865 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Meng Yan <[email protected]> Co-authored-by: Claude <[email protected]>
Problem - MNIST download links for https://yann.lecun.com/exdb/mnist are not working for sometime now and the system tends to download it from https://ossci-datasets.s3.amazonaws.com/mnist eventually.
This is unnecessarily adding to the execution time + failure messages.
Solution - I have simply reversed the order of mirror links, so that it tries the working one first resulting in minimal execution time. Also, once the yann.lecun.com starts working, it will anyways be part of the list.