More datapoints docs and comments #7830
Conversation
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Just few comments otherwise looks good to me. Thanks!
| # above in :ref:`datapoint_creation`): | ||
|
|
||
| new_bboxes = bboxes + 3 | ||
| new_bboxes = datapoints.BoundingBoxes.wrap_like(bboxes, new_bboxes) |
There was a problem hiding this comment.
non-blocking thought to reduce the number of chars to type, it could be simple to have bboxes.wrap_like(new_bboxes) or bboxes.wrap_to(new_bboxes).
I think we already thought about that earlier but failed to get a good naming ...
There was a problem hiding this comment.
Yeah, I find it a bit long and clunky as well.
bboxes.wrap_to(new_bboxes).
That would be the best UX but unfortunately we can't do that because wrap_to would have to be a method on pure Tensors.
We can implement instance methods on BBoxes objects, but I can't think of a good name either right now
There was a problem hiding this comment.
We have #7780 to go from BoundingBoxes to BBoxes. I'm somewhat against doing bboxes.wrap_like(...) here, since it no longer makes it clear that this is a class and not instance method.
| # above in :ref:`datapoint_creation`): | ||
|
|
||
| new_bboxes = bboxes + 3 | ||
| new_bboxes = datapoints.BoundingBoxes.wrap_like(bboxes, new_bboxes) |
There was a problem hiding this comment.
We have #7780 to go from BoundingBoxes to BBoxes. I'm somewhat against doing bboxes.wrap_like(...) here, since it no longer makes it clear that this is a class and not instance method.
Co-authored-by: vfdev <[email protected]>
Summary: Co-authored-by: vfdev <[email protected]> Reviewed By: matteobettini Differential Revision: D48642271 fbshipit-source-id: 8982f6b16044a1f0877db664fc099b74049dcdff
4 participants
No description provided.