Change default pytest traceback from native to short #7810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
approved these changes
Aug 9, 2023
Contributor
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
No objections here. IIRC, we just copied the configuration from core and they had --tb=native, because it supposedly (I've never checked) better for tracebacks that start in the C++ layer.
Member
Author
|
Ah OK, good to keep in mind. Considering we very rarely do C++ stuff I guess it's still fine. LMK if you notice any undersirable change on your setup |
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added
code quality
other
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Reviewed By: matteobettini Differential Revision: D48642269 fbshipit-source-id: 1eff194c0283b1aad0994bf9e58691ffc7d1b4ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDK why but
shortlooks much better on my terminal (and it's the same size)native:
short:
