fix MNIST byte flipping #7081
Merged
fix MNIST byte flipping #7081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jan 12, 2023
Member
There was a problem hiding this comment.
Thanks Philip.
Before merging, could we add some quick test for the endianness conversion (possibly requiring extracting it in a separate function)?
Something along these lines:
t = torch.tensor([0x00112233, 0xaabbccdd], dtype=float.torch32)
flipped = torch.tensor([0x33221100, 0xddccbbaa], dtype=float.torch32)
assert flip_endianness(t) == flippedIdeally we'd test the QMnist dataset directly, but this may make the tests just as complicated as the code (which kinds defeats the purpose of the test)
NicolasHug
approved these changes
Jan 12, 2023
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @pmeier , some comments but LGTM
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Summary: * fix MNIST byte flipping * add test * move to utils * remove lazy import Reviewed By: YosuaMichael Differential Revision: D42500904 fbshipit-source-id: 067064facc22efc68368d06dccd4fa2e2fa6dfc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7079.