expand ToDtype to support multiple conversions at once #6756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Oct 12, 2022
datumbox
reviewed
Oct 12, 2022
Contributor
Author
|
@datumbox You were right. I made it too complex for no apparent reason. I simplified. PTAL. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Summary: * expand ToDtype to support multiple conversions at once * simplify Reviewed By: NicolasHug Differential Revision: D40427455 fbshipit-source-id: 2d8f29ea19f9715872c4a4484ee118ff75bfdef2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6697.