MNIST and FashionMNIST now have their own 'raw' and 'processed' folders #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
requested changes
Sep 13, 2018
Member
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
This overall looks good, thanks!
But this patch makes MNIST Python3 only, so this needs to be changed.
torchvision/datasets/mnist.py
Outdated
| pass | ||
| else: | ||
| raise | ||
| os.makedirs(self.raw_folder, exist_ok=True) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Ready. |
fmassa
requested changes
Sep 17, 2018
Member
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
This looks very good, and is almost ready to be merged.
I have a single comment, can you address it so that I can merge this?
Thanks a lot, the code is looking much better!
knakad
added a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Aug 16, 2019
This commit will modify the folder structure to avoid needing to download the datasets and relying on the dataset website from being available. This caused a canary to fail (TT-0407832742). The dependency has existed since Pytorch 1.1 upgrade, as the directory structure was modified in pytorch/vision#601
4 tasks
knakad
added a commit
to aws/sagemaker-python-sdk
that referenced
this pull request
Aug 16, 2019
This commit will modify the folder structure to avoid needing to download the datasets and relying on the dataset website from being available. This caused a canary to fail. The dependency has existed since Pytorch 1.1 upgrade, as the directory structure was modified in pytorch/vision#601
rajveerb
pushed a commit
to rajveerb/vision
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #599.