Fetch completed data based on workflowIds instead of timerange #7515
+96
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
yangw-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fetch completed data based on workflowIds instead of time range, since it may cutoff data. similar to compiler regression logics, we want to apply this to other benchmarks too
Improve
Fetch benchmark data based on list of workflows, this makes sure data does not cut off due to the time range select.
Demo
Access:
to access the benchmark ui in preivew login with credential from
https://vercel.com/fbopensource/torchci/settings/environment-variables
PREVIEW_USER
PREVIEW_PASS
https://torchci-git-basedcommits-fbopensource.vercel.app/benchmark/v3/dashboard/pytorch_helion
https://torchci-git-basedcommits-fbopensource.vercel.app/benchmark/v3/dashboard/pytorch_operator_microbenchmark