Skip to content

Fix rare test_binary_input failure in Precision & Recall #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 2 commits into from
Sep 9, 2022
Merged

Fix rare test_binary_input failure in Precision & Recall #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f0ad00
Fix rare test_binary_input failure in Precision & Recall
sadra-barikbin Sep 9, 2022
4241ff7
Merge branch 'master' into Fix-rare-failure-binary-test-precision-recall
vfdev-5 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/ignite/metrics/test_precision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ def _test(y_pred, y, batch_size):
assert isinstance(pr.compute(), torch.Tensor if not average else float)
pr_compute = pr.compute().numpy() if not average else pr.compute()
sk_average_parameter = ignite_average_to_scikit_average(average, "binary")
assert precision_score(np_y, np_y_pred, average=sk_average_parameter, zero_division=0) == pytest.approx(
pr_compute
)
assert precision_score(
np_y, np_y_pred, average=sk_average_parameter, labels=[0, 1], zero_division=0
) == pytest.approx(pr_compute)

def get_test_cases():

Expand Down
2 changes: 1 addition & 1 deletion tests/ignite/metrics/test_recall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def _test(y_pred, y, batch_size):
assert isinstance(re.compute(), torch.Tensor if not average else float)
re_compute = re.compute().numpy() if not average else re.compute()
sk_average_parameter = ignite_average_to_scikit_average(average, "binary")
assert recall_score(np_y, np_y_pred, average=sk_average_parameter) == pytest.approx(re_compute)
assert recall_score(np_y, np_y_pred, average=sk_average_parameter, labels=[0, 1]) == pytest.approx(re_compute)

def get_test_cases():

Expand Down