Skip to content

solves AttributeError: 'State' object has no attribute 'rng_states' #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vfdev-5 merged 9 commits into from
Jan 10, 2022
Merged

solves AttributeError: 'State' object has no attribute 'rng_states' #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8159dcf
solves AttributeError: 'State' object has no attribute 'rng_states'
bibhabasumohapatra Jan 7, 2022
e1e58b5
update state_dict
bibhabasumohapatra Jan 9, 2022
515952b
trying test_state_dict in deterministic Engine
bibhabasumohapatra Jan 9, 2022
fac9da4
autopep8 fix
bibhabasumohapatra Jan 9, 2022
fa48cac
update test_deterministic.py
bibhabasumohapatra Jan 9, 2022
093a375
Update test_deterministic.py
bibhabasumohapatra Jan 9, 2022
61d9b00
autopep8 fix
bibhabasumohapatra Jan 9, 2022
82dec14
update deterministic.py
bibhabasumohapatra Jan 10, 2022
d14e8ce
update deterministic.py
bibhabasumohapatra Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ignite/engine/deterministic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ class DeterministicEngine(Engine):
def __init__(self, process_function: Callable[[Engine, Any], Any]):
super(DeterministicEngine, self).__init__(process_function)
self.state_dict_user_keys.append("rng_states")
if not hasattr(self.state, "rng_states"):
setattr(self.state, "rng_states", None)
self.add_event_handler(Events.STARTED, self._init_run)
self.add_event_handler(Events.DATALOADER_STOP_ITERATION | Events.TERMINATE_SINGLE_EPOCH, self._setup_seed)

Expand All @@ -189,9 +191,6 @@ def state_dict(self) -> OrderedDict:

def _init_run(self) -> None:
self.state.seed = int(torch.randint(0, int(1e9), (1,)).item())
if not hasattr(self.state, "rng_states"):
setattr(self.state, "rng_states", None)

if torch.cuda.is_available():
torch.backends.cudnn.deterministic = True
torch.backends.cudnn.benchmark = False
Expand Down
11 changes: 11 additions & 0 deletions tests/ignite/engine/test_deterministic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import random
import sys
from collections.abc import Mapping
from unittest.mock import patch

import numpy as np
Expand Down Expand Up @@ -893,3 +894,13 @@ def test_engine_no_data_asserts():

with pytest.raises(ValueError, match=r"Deterministic engine does not support the option of data=None"):
trainer.run(max_epochs=10, epoch_length=10)


def test_state_dict():
engine = DeterministicEngine(lambda e, b: 1)
sd = engine.state_dict()
assert isinstance(sd, Mapping) and len(sd) == 4
assert "iteration" in sd and sd["iteration"] == 0
assert "max_epochs" in sd and sd["max_epochs"] is None
assert "epoch_length" in sd and sd["epoch_length"] is None
assert "rng_states" in sd and sd["rng_states"] is not None