Skip to content

Commit 25e027c

Browse files
soma2000-langSomasreevfdev-5
authored
Dropper TrainsLoger and TrainsSaver also removed the backward compati… (#2742)
* Dropper TrainsLoger and TrainsSaver also removed the backward compatibility * Update clearml_logger.py * Update handlers.rst * Replaced RuntimeError with ModuleNotFoundError * Update ignite/contrib/handlers/clearml_logger.py Co-authored-by: Somasree <[email protected]> Co-authored-by: vfdev <[email protected]>
1 parent 3a8ca5f commit 25e027c

File tree

5 files changed

+7
-34
lines changed

5 files changed

+7
-34
lines changed

docs/source/contrib/handlers.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Loggers
4242
polyaxon_logger
4343
tensorboard_logger
4444
tqdm_logger
45-
trains_logger
45+
4646
visdom_logger
4747
wandb_logger
4848

ignite/contrib/handlers/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from ignite.contrib.handlers.polyaxon_logger import PolyaxonLogger
55
from ignite.contrib.handlers.tensorboard_logger import TensorboardLogger
66
from ignite.contrib.handlers.tqdm_logger import ProgressBar
7-
from ignite.contrib.handlers.trains_logger import TrainsLogger
7+
88
from ignite.contrib.handlers.visdom_logger import VisdomLogger
99
from ignite.contrib.handlers.wandb_logger import WandBLogger
1010
from ignite.handlers import EpochOutputStore, global_step_from_engine # ref # ref

ignite/contrib/handlers/clearml_logger.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,10 @@ def __init__(self, **kwargs: Any):
115115
from clearml import Task
116116
from clearml.binding.frameworks.tensorflow_bind import WeightsGradientHistHelper
117117
except ImportError:
118-
try:
119-
# Backwards-compatibility for legacy Trains SDK
120-
from trains import Task
121-
from trains.binding.frameworks.tensorflow_bind import WeightsGradientHistHelper
122-
except ImportError:
123-
raise RuntimeError(
124-
"This contrib module requires clearml to be installed. "
125-
"You may install clearml using: \n pip install clearml \n"
126-
)
118+
raise RuntimeError(
119+
"This contrib module requires clearml to be installed. "
120+
"You may install clearml using: \n pip install clearml \n"
121+
)
127122

128123
experiment_kwargs = {k: v for k, v in kwargs.items() if k not in ("project_name", "task_name", "task_type")}
129124

ignite/contrib/handlers/trains_logger.py

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/ignite/contrib/handlers/test_clearml_logger.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,11 @@
2121
WeightsHistHandler,
2222
WeightsScalarHandler,
2323
)
24-
from ignite.contrib.handlers.trains_logger import TrainsLogger
24+
2525
from ignite.engine import Engine, Events, State
2626
from ignite.handlers import Checkpoint
2727

2828

29-
def test_trains_logger_alias(dirname):
30-
with pytest.warns(UserWarning, match="ClearMLSaver: running in bypass mode"):
31-
TrainsLogger.set_bypass_mode(True)
32-
logger = TrainsLogger(output_uri=dirname)
33-
assert isinstance(logger, ClearMLLogger)
34-
35-
3629
def test_optimizer_params_handler_wrong_setup():
3730

3831
with pytest.raises(TypeError):

0 commit comments

Comments
 (0)