Infra: Fix Replaces/Superseded-By/Requires links for dirhtml #2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
changed the title
CAM-Gerlach
approved these changes
Jan 24, 2023
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @hugovk ! I tested all the various cases from the previous, and everything works great. LGTM!
Member
|
Since this is a straightforward but critical fix and you're hopefully already asleep, I'll go ahead and merge this. |
JelleZijlstra
pushed a commit
to JelleZijlstra/peps
that referenced
this pull request
Jan 24, 2023
…2981) After python#2972, when building dirhtml, we need to re-add the initial / for the links to PEPs in the Replaces/Superseded-By/Requires headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2980.
After #2972, when building
dirhtml, we need to re-add the initial/for the links to PEPs in the Replaces/Superseded-By/Requires headers.Demo
https://pep-previews--2981.org.readthedocs.build/pep-0509/ <--> https://pep-previews--2981.org.readthedocs.build/pep-0699/