[mypyc] Match int arguments to primitives with native int params #20299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `int` argument values didn't match if a primitive parameter type was `u8`, for example, requiring generic operations to be used, or an explicit `u8` conversion/cast/type annotation. Now we perform a second matching pass with relaxed subtyping rules that allow `int` to match with any native int type if strict matching didn't produce a result. As an optimization, only perform this if any primitives use native integer types (most don't).
p-sawicki
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
intargument values didn't match if a primitive parameter type wasu8, for example, requiring generic operations to be used, or an explicitu8conversion/cast/type annotation.Now we perform a second matching pass with relaxed subtyping rules that allow
intto match with any native int type if strict matching didn't produce a result. As an optimization, only perform this if any primitives use native integer types (most don't).