Include new option in cherry-picker config dict#639
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #639 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 360 360
Branches 14 14
=========================================
Hits 360 360
Flags with carried forward coverage won't be shown. Click here to find out more. |
ambv
reviewed
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be necessary when python/cherry-picker#70 is merged. It would maybe be somewhat better to use
cherry_picker.load_config()(or simply not specify the config which will default to the equivalentcherry_picker.DEFAULT_CONFIG) instead of hard-coding the configuration but I opted to just keep this consistent with what's already in the code base.Since this project doesn't pin the version of cherry-picker, the merge of this will need to happen before the merge of the aforementioned PR. I haven't received feedback on the name of this config option though so I'm not entirely sure if it will stay like this.