From 223a366fe8eac7b68a39af56aadff7d58659d632 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Randy=20D=C3=B6ring?= <30527984+radoering@users.noreply.github.com> Date: Thu, 26 May 2022 15:27:25 +0200 Subject: [PATCH] test(solver): increase test coverage by searching for copies instead of the same instance --- .../version_solver/test_dependency_cache.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/mixology/version_solver/test_dependency_cache.py b/tests/mixology/version_solver/test_dependency_cache.py index 03f247abca4..423573876ff 100644 --- a/tests/mixology/version_solver/test_dependency_cache.py +++ b/tests/mixology/version_solver/test_dependency_cache.py @@ -1,5 +1,6 @@ from __future__ import annotations +from copy import deepcopy from typing import TYPE_CHECKING from poetry.factory import Factory @@ -34,8 +35,10 @@ def test_solver_dependency_cache_respects_source_type( cache.search_for(dependency_git) assert not cache.search_for.cache_info().hits - packages_pypi = cache.search_for(dependency_pypi) - packages_git = cache.search_for(dependency_git) + # increase test coverage by searching for copies + # (when searching for the exact same object, __eq__ is never called) + packages_pypi = cache.search_for(deepcopy(dependency_pypi)) + packages_git = cache.search_for(deepcopy(dependency_git)) assert cache.search_for.cache_info().hits == 2 assert cache.search_for.cache_info().currsize == 2 @@ -90,8 +93,10 @@ def test_solver_dependency_cache_respects_subdirectories( cache.search_for(dependency_one_copy) assert not cache.search_for.cache_info().hits - packages_one = cache.search_for(dependency_one) - packages_one_copy = cache.search_for(dependency_one_copy) + # increase test coverage by searching for copies + # (when searching for the exact same object, __eq__ is never called) + packages_one = cache.search_for(deepcopy(dependency_one)) + packages_one_copy = cache.search_for(deepcopy(dependency_one_copy)) assert cache.search_for.cache_info().hits == 2 assert cache.search_for.cache_info().currsize == 2