Skip to content

Commit a770b3a

Browse files
authored
package category is not useful (#7637)
package.category doesn't make a lot of sense in the richer world of dependency groups. The only use that is made of the category in poetry and poetry-core is that it is written to and read back from the lockfile. But no use is made of that information.
1 parent ec35b83 commit a770b3a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+5
-454
lines changed

src/poetry/packages/locker.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ def locked_repository(self) -> LockfileRepository:
126126
source_subdirectory=source.get("subdirectory"),
127127
)
128128
package.description = info.get("description", "")
129-
package.category = info.get("category", "main")
130129
package.optional = info["optional"]
131130
metadata = cast("dict[str, Any]", lock_data["metadata"])
132131

@@ -425,7 +424,6 @@ def _dump_package(self, package: Package) -> dict[str, Any]:
425424
"name": package.pretty_name,
426425
"version": package.pretty_version,
427426
"description": package.description or "",
428-
"category": package.category,
429427
"optional": package.optional,
430428
"python-versions": package.python_versions,
431429
"files": sorted(

src/poetry/puzzle/solver.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
from typing import Tuple
1010
from typing import TypeVar
1111

12-
from poetry.core.packages.dependency_group import MAIN_GROUP
13-
1412
from poetry.mixology import resolve_version
1513
from poetry.mixology.failure import SolveFailure
1614
from poetry.puzzle.exceptions import OverrideNeeded
@@ -273,11 +271,9 @@ def __init__(
273271
self.depth = -1
274272

275273
if not previous:
276-
self.category = "dev"
277274
self.groups: frozenset[str] = frozenset()
278275
self.optional = True
279276
elif dep:
280-
self.category = "main" if MAIN_GROUP in dep.groups else "dev"
281277
self.groups = dep.groups
282278
self.optional = dep.is_optional()
283279
else:
@@ -327,14 +323,11 @@ def aggregate_package_nodes(nodes: list[PackageNode]) -> tuple[Package, int]:
327323
for node in nodes:
328324
groups.extend(node.groups)
329325

330-
category = "main" if any(MAIN_GROUP in node.groups for node in nodes) else "dev"
331326
optional = all(node.optional for node in nodes)
332327
for node in nodes:
333328
node.depth = depth
334-
node.category = category
335329
node.optional = optional
336330

337-
package.category = category
338331
package.optional = optional
339332

340333
return package, depth

tests/console/commands/self/test_remove_plugins.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ def install_plugin(installed: Repository) -> None:
4545
{
4646
"name": "poetry-plugin",
4747
"version": "1.2.3",
48-
"category": "main",
4948
"optional": False,
5049
"platform": "*",
5150
"python-versions": "*",

0 commit comments

Comments
 (0)