Fix encoding warnings with PEP 597 enabled

Author: danyeaw

.github/workflows/tests.yaml

@@ -13,6 +13,9 @@ defaults:
   run:
     shell: bash
 
+env:
+  PYTHONWARNDEFAULTENCODING: 'true'
+
 jobs:
   changes:
     name: Detect changed files

src/poetry/masonry/builders/editable.py

@@ -3,7 +3,6 @@
 import csv
 import hashlib
 import json
-import locale
 import os
 
 from base64 import urlsafe_b64encode
@@ -16,6 +15,7 @@
 
 from poetry.utils._compat import WINDOWS
 from poetry.utils._compat import decode
+from poetry.utils._compat import getencoding
 from poetry.utils.env import build_environment
 from poetry.utils.helpers import is_dir_writable
 from poetry.utils.pip import pip_install
@@ -125,7 +125,7 @@ def _add_pth(self) -> list[Path]:
 
         try:
             pth_file = self._env.site_packages.write_text(
-                pth_file, content, encoding=locale.getpreferredencoding()
+                pth_file, content, encoding=getencoding()
             )
             self._debug(
                 f"  - Adding <c2>{pth_file.name}</c2> to <b>{pth_file.parent}</b> for"
@@ -252,7 +252,8 @@ def _add_dist_info(self, added_files: list[Path]) -> None:
                     "dir_info": {"editable": True},
                     "url": self._poetry.file.path.parent.absolute().as_uri(),
                 }
-            )
+            ),
+            encoding="utf-8",
         )
         added_files.append(direct_url_json)
 

src/poetry/repositories/installed_repository.py

@@ -13,6 +13,7 @@
 from poetry.core.utils.helpers import module_name
 
 from poetry.repositories.repository import Repository
+from poetry.utils._compat import getencoding
 from poetry.utils._compat import metadata
 
 
@@ -58,7 +59,7 @@ def get_package_paths(cls, env: Env, name: str) -> set[Path]:
             if not pth_file.exists():
                 continue
 
-            with pth_file.open() as f:
+            with pth_file.open(encoding=getencoding()) as f:
                 for line in f:
                     line = line.strip()
                     if line and not line.startswith(("#", "import ", "import\t")):

src/poetry/utils/_compat.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import locale
 import sys
 
 from contextlib import suppress
@@ -52,6 +53,13 @@ def encode(string: str, encodings: list[str] | None = None) -> bytes:
     return string.encode(encodings[0], errors="ignore")
 
 
+def getencoding() -> str:
+    if sys.version_info < (3, 11):
+        return locale.getpreferredencoding()
+    else:
+        return locale.getencoding()
+
+
 def is_relative_to(this: Path, other: Path) -> bool:
     """
     Return whether `this` path is relative to the `other` path. This is compatibility wrapper around
@@ -72,6 +80,7 @@ def is_relative_to(this: Path, other: Path) -> bool:
     "WINDOWS",
     "decode",
     "encode",
+    "getencoding",
     "is_relative_to",
     "metadata",
     "tomllib",

src/poetry/utils/env/base_env.py

@@ -330,8 +330,9 @@ def _run(self, cmd: list[str], **kwargs: Any) -> str:
                 subprocess.check_call(cmd, stderr=stderr, env=env, **kwargs)
                 output = ""
             else:
+                encoding = "locale" if sys.version_info >= (3, 10) else None
                 output = subprocess.check_output(
-                    cmd, stderr=stderr, env=env, text=True, **kwargs
+                    cmd, stderr=stderr, env=env, text=True, encoding=encoding, **kwargs
                 )
         except CalledProcessError as e:
             raise EnvCommandError(e)

src/poetry/utils/env/virtual_env.py

@@ -136,7 +136,7 @@ def includes_system_site_packages(self) -> bool:
         return pyvenv_cfg.exists() and (
             re.search(
                 r"^\s*include-system-site-packages\s*=\s*true\s*$",
-                pyvenv_cfg.read_text(),
+                pyvenv_cfg.read_text(encoding="utf-8"),
                 re.IGNORECASE | re.MULTILINE,
             )
             is not None

src/poetry/utils/setup_reader.py

@@ -40,12 +40,13 @@ def run(*args: Any, **kwargs: Any) -> None:
         git_command = find_git_command()
         env = os.environ.copy()
         env["GIT_TERMINAL_PROMPT"] = "0"
-        subprocess.check_call(
+        subprocess.check_call(  # type: ignore[call-arg]
             git_command + list(args),
             stderr=subprocess.DEVNULL,
             stdout=subprocess.DEVNULL,
             env=env,
             text=True,
+            encoding="utf-8",
         )
 
     @staticmethod

src/poetry/vcs/git/system.py

@@ -76,13 +76,18 @@ def test_remove_all(
     if envs_file == "empty":
         envs_file_path.touch()
     elif envs_file == "self":
-        envs_file_path.write_text(f'[{venv_name}]\nminor = "3.9"\npatch = "3.9.1"\n')
+        envs_file_path.write_text(
+            f'[{venv_name}]\nminor = "3.9"\npatch = "3.9.1"\n', encoding="utf-8"
+        )
     elif envs_file == "other":
-        envs_file_path.write_text('[other-abcdefgh]\nminor = "3.9"\npatch = "3.9.1"\n')
+        envs_file_path.write_text(
+            '[other-abcdefgh]\nminor = "3.9"\npatch = "3.9.1"\n', encoding="utf-8"
+        )
     elif envs_file == "self_and_other":
         envs_file_path.write_text(
             f'[{venv_name}]\nminor = "3.9"\npatch = "3.9.1"\n'
-            '[other-abcdefgh]\nminor = "3.9"\npatch = "3.9.1"\n'
+            '[other-abcdefgh]\nminor = "3.9"\npatch = "3.9.1"\n',
+            encoding="utf-8",
         )
     else:
         # no envs file -> nothing to prepare
@@ -97,7 +102,7 @@ def test_remove_all(
 
     if envs_file is not None:
         assert envs_file_path.exists()
-        envs_file_content = envs_file_path.read_text()
+        envs_file_content = envs_file_path.read_text(encoding="utf-8")
         assert venv_name not in envs_file_content
         if "other" in envs_file:
             assert "other-abcdefgh" in envs_file_content

tests/console/commands/env/test_remove.py

@@ -45,7 +45,7 @@ def test_self_install(
     assert isinstance(command, SelfInstallCommand)
     pyproject_path = command.system_pyproject
     if pyproject_content:
-        pyproject_path.write_text(pyproject_content)
+        pyproject_path.write_text(pyproject_content, encoding="utf-8")
     else:
         assert not pyproject_path.exists()