Skip to content

Commit d00b6ec

Browse files
charlesbeattiecopybara-github
authored andcommitted
Support assigning repeated scalar fields using Python Buffer API.
PiperOrigin-RevId: 918392317
1 parent 8c2fe74 commit d00b6ec

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

pybind11_protobuf/tests/message_test.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,11 @@ def test_access_repeated_int_value(self, factory):
104104
del message.repeated_int_value[1:3]
105105
self.assertSequenceEqual(message.repeated_int_value, [8, 5])
106106

107+
message.repeated_int_value.remove(8)
108+
self.assertSequenceEqual(message.repeated_int_value, [5])
109+
with self.assertRaises(ValueError):
110+
message.repeated_int_value.remove(8)
111+
107112
del message.repeated_int_value[:]
108113
self.assertEmpty(message.repeated_int_value)
109114

@@ -191,6 +196,13 @@ def check_values(messages, expected_values):
191196
del message.repeated_int_message[2:4]
192197
check_values(message.repeated_int_message, [8, 7, 0, 3])
193198

199+
to_remove = message.repeated_int_message[1]
200+
self.assertEqual(to_remove.value, 7)
201+
message.repeated_int_message.remove(to_remove)
202+
check_values(message.repeated_int_message, [8, 0, 3])
203+
with self.assertRaises(ValueError):
204+
message.repeated_int_message.remove(to_remove)
205+
194206
del message.repeated_int_message[:]
195207
self.assertEmpty(message.repeated_int_message)
196208

0 commit comments

Comments
 (0)