Use push_back with const char * instead of emplace_back

YannickJadoul · YannickJadoul · commit be9091084533 · 2021-01-13T16:27:37.000+01:00
diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
@@ -243,7 +243,7 @@ class cpp_function : public function {
         }
         char *operator()(const char *s) {
             auto t = strdup(s);
-            strings.emplace_back(t);
+            strings.push_back(t);
             return t;
         }
         void release() {

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ class cpp_function : public function {`
`243`	`243`	`}`
`244`	`244`	`char operator()(const char s) {`
`245`	`245`	`auto t = strdup(s);`
`246`		`- strings.emplace_back(t);`
	`246`	`+ strings.push_back(t);`
`247`	`247`	`return t;`
`248`	`248`	`}`
`249`	`249`	`void release() {`