Implicit string concatenation

Author: MartinThoma

PyPDF2/filters.py

@@ -363,7 +363,7 @@ def decode(data, decodeParms=None, height=0):
 
         width = decodeParms["/Columns"]
         imgSize = len(data)
-        tiff_header_struct = '<' + '2s' + 'h' + 'l' + 'h' + 'hhll' * 8 + 'h'
+        tiff_header_struct = '<2shlh' + 'hhll' * 8 + 'h'
         tiffHeader = struct.pack(tiff_header_struct,
                            b'II',  # Byte order indication: Little endian
                            42,  # Version number (always 42)

PyPDF2/pagerange.py

@@ -144,7 +144,7 @@ def parse_filename_page_ranges(args):
     for arg in args + [None]:
         if PageRange.valid(arg):
             if not pdf_filename:
-                raise ValueError("The first argument must be a filename, " \
+                raise ValueError("The first argument must be a filename, "
                                  "not a page range.")
 
             pairs.append( (pdf_filename, PageRange(arg)) )

requirements/ci.in

@@ -1,5 +1,6 @@
 pytest
 flake8
 flake8-bugbear
+flake8_implicit_str_concat
 pytest-cov
 pillow

requirements/ci.txt

@@ -4,9 +4,10 @@
 #
 #    pip-compile requirements/ci.in
 #
-attrs==21.4.0
+attrs==20.3.0
     # via
     #   flake8-bugbear
+    #   flake8-implicit-str-concat
     #   pytest
 coverage[toml]==6.2
     # via pytest-cov
@@ -16,6 +17,8 @@ flake8==4.0.1
     #   flake8-bugbear
 flake8-bugbear==22.3.23
     # via -r requirements/ci.in
+flake8-implicit-str-concat==0.2.0
+    # via -r requirements/ci.in
 importlib-metadata==4.2.0
     # via
     #   flake8
@@ -25,6 +28,8 @@ iniconfig==1.1.1
     # via pytest
 mccabe==0.6.1
     # via flake8
+more-itertools==8.12.0
+    # via flake8-implicit-str-concat
 packaging==21.3
     # via pytest
 pillow==8.4.0