(PE-38998) Include getoptlong for bolt-server main #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet 8 now has an explict dep on getoptlong puppetlabs/puppet@5bce3bb This is a "default" gem for ruby 3. When orchestrator's jruby tries to load bolt it cant find the default gems. This commit explictly packages the getoptlong gem outside of the default gems.
donoghuc
force-pushed
the
PE-38998-getoptlong
branch
from
0428b67 to
a184595
Compare
austb
approved these changes
Aug 9, 2024
Contributor
austb
left a comment
austb
left a comment
There was a problem hiding this comment.
Could pull in a newer version, but LGTM 👍🏻
| @@ -0,0 +1,6 @@ | |||
| component 'rubygem-getoptlong' do |pkg, settings, platform| | |||
| pkg.version '0.2.0' | |||
Contributor
There was a problem hiding this comment.
Version 0.2.1 exists if we want to use that. Puppet's dep is "~> 0.2.0" so it is probably pulling the new version in. But a quick scan of the changes between the two looks unimportant to me.
Contributor
Author
There was a problem hiding this comment.
i wan to make sure i have the same version as the default in our version of ruby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 8 now has an explict dep on getoptlong puppetlabs/puppet@5bce3bb This is a "default" gem for ruby 3. When orchestrator's jruby tries to load bolt it cant find the default gems. This commit explictly packages the getoptlong gem outside of the default gems.