feat(primitives): add BuilderIndex SSZ type - #16169
Merged
Merged
Conversation
nalepae
reviewed
Dec 19, 2025
| ) | ||
|
|
||
| func TestBuilderIndex_SSZRoundTripAndHashRoot(t *testing.T) { | ||
| t.Parallel() |
Contributor
There was a problem hiding this comment.
It t.Parallel() needed here since it is already done in subtests?
nalepae
reviewed
Dec 19, 2025
| } | ||
|
|
||
| func TestBuilderIndex_UnmarshalSSZRejectsWrongSize(t *testing.T) { | ||
| t.Parallel() |
Contributor
There was a problem hiding this comment.
It t.Parallel() needed here since it is already done in subtests?
nalepae
previously approved these changes
Dec 19, 2025
nalepae
previously approved these changes
Dec 19, 2025
nalepae
approved these changes
Dec 19, 2025
james-prysm
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds primitives.BuilderIndex for builder registry indexing in Gloas