diff --git a/python/google/protobuf/json_format.py b/python/google/protobuf/json_format.py index a031c7f5b3f01..afc7d0e23edf7 100644 --- a/python/google/protobuf/json_format.py +++ b/python/google/protobuf/json_format.py @@ -26,6 +26,7 @@ import math from operator import methodcaller import re +import warnings from google.protobuf import descriptor from google.protobuf import message_factory @@ -191,6 +192,11 @@ def __init__( self.use_integers_for_enums = use_integers_for_enums self.descriptor_pool = descriptor_pool if float_precision: + warnings.warn( + 'float_precision option is deprecated for json_format. ' + 'This will turn into error in 7.34.0, please remove it ' + 'before that.' + ) self.float_format = '.{}g'.format(float_precision) else: self.float_format = None diff --git a/python/google/protobuf/text_format.py b/python/google/protobuf/text_format.py index c5da005388209..a3566ee3ded95 100644 --- a/python/google/protobuf/text_format.py +++ b/python/google/protobuf/text_format.py @@ -25,6 +25,7 @@ import io import math import re +import warnings from google.protobuf.internal import decoder from google.protobuf.internal import type_checkers @@ -416,6 +417,10 @@ def __init__( self.use_index_order = use_index_order self.float_format = float_format if double_format is not None: + warnings.warn( + 'double_format is deprecated for text_format. This will ' + 'turn into error in 7.34.0, please remove it before that.' + ) self.double_format = double_format else: self.double_format = float_format @@ -652,6 +657,11 @@ def PrintFieldValue(self, field, value): out.write('false') elif field.cpp_type == descriptor.FieldDescriptor.CPPTYPE_FLOAT: if self.float_format is not None: + warnings.warn( + 'float_format is deprecated for text_format. This ' + 'will turn into error in 7.34.0, please remove it ' + 'before that.' + ) out.write('{1:{0}}'.format(self.float_format, value)) else: if math.isnan(value):