Skip to content

Commit 94a2a44

Browse files
protobuf-github-botcopybara-github
protobuf-github-bot
authored and
copybara-github
committed
Breaking Change: remove unnecessary overloads of methods:
hasExtension getExtensionCount getExtension PiperOrigin-RevId: 597702196
1 parent cdcd166 commit 94a2a44

File tree

1 file changed

+0
-258
lines changed

1 file changed

+0
-258
lines changed

‎java/core/src/main/java/com/google/protobuf/GeneratedMessage.java‎

Lines changed: 0 additions & 258 deletions
Original file line numberDiff line numberDiff line change
@@ -975,57 +975,6 @@ public interface ExtendableMessageOrBuilder<MessageT extends ExtendableMessage<M
975975

976976
/** Get one element of a repeated extension. */
977977
<T> T getExtension(ExtensionLite<MessageT, List<T>> extension, int index);
978-
979-
/**
980-
* Check if a singular extension is present.
981-
* <p>TODO: handled by ExtensionLite version
982-
*/
983-
<T> boolean hasExtension(
984-
Extension<MessageT, T> extension);
985-
/**
986-
* Check if a singular extension is present.
987-
* <p>TODO: handled by ExtensionLite version
988-
*/
989-
<T> boolean hasExtension(
990-
GeneratedExtension<MessageT, T> extension);
991-
/**
992-
* Get the number of elements in a repeated extension.
993-
* <p>TODO: handled by ExtensionLite version
994-
*/
995-
<T> int getExtensionCount(
996-
Extension<MessageT, List<T>> extension);
997-
/**
998-
* Get the number of elements in a repeated extension.
999-
* <p>TODO: handled by ExtensionLite version
1000-
*/
1001-
<T> int getExtensionCount(
1002-
GeneratedExtension<MessageT, List<T>> extension);
1003-
/**
1004-
* Get the value of an extension.
1005-
* <p>TODO: handled by ExtensionLite version
1006-
*/
1007-
<T> T getExtension(
1008-
Extension<MessageT, T> extension);
1009-
/**
1010-
* Get the value of an extension.
1011-
* <p>TODO: handled by ExtensionLite version
1012-
*/
1013-
<T> T getExtension(
1014-
GeneratedExtension<MessageT, T> extension);
1015-
/**
1016-
* Get one element of a repeated extension.
1017-
* <p>TODO: handled by ExtensionLite version
1018-
*/
1019-
<T> T getExtension(
1020-
Extension<MessageT, List<T>> extension,
1021-
int index);
1022-
/**
1023-
* Get one element of a repeated extension.
1024-
* <p>TODO: handled by ExtensionLite version
1025-
*/
1026-
<T> T getExtension(
1027-
GeneratedExtension<MessageT, List<T>> extension,
1028-
int index);
1029978
}
1030979

1031980
/**
@@ -1142,77 +1091,6 @@ public final <T> T getExtension(
11421091
extension.singularFromReflectionType(extensions.getRepeatedField(descriptor, index));
11431092
}
11441093

1145-
/**
1146-
* Check if a singular extension is present.
1147-
* <p>TODO: handled by ExtensionLite version
1148-
*/
1149-
@Override
1150-
public final <T> boolean hasExtension(final Extension<MessageT, T> extension) {
1151-
return hasExtension((ExtensionLite<MessageT, T>) extension);
1152-
}
1153-
/**
1154-
* Check if a singular extension is present.
1155-
* <p>TODO: handled by ExtensionLite version
1156-
*/
1157-
@Override
1158-
public final <T> boolean hasExtension(
1159-
final GeneratedExtension<MessageT, T> extension) {
1160-
return hasExtension((ExtensionLite<MessageT, T>) extension);
1161-
}
1162-
/**
1163-
* Get the number of elements in a repeated extension.
1164-
* <p>TODO: handled by ExtensionLite version
1165-
*/
1166-
@Override
1167-
public final <T> int getExtensionCount(
1168-
final Extension<MessageT, List<T>> extension) {
1169-
return getExtensionCount((ExtensionLite<MessageT, List<T>>) extension);
1170-
}
1171-
/**
1172-
* Get the number of elements in a repeated extension.
1173-
* <p>TODO: handled by ExtensionLite version
1174-
*/
1175-
@Override
1176-
public final <T> int getExtensionCount(
1177-
final GeneratedExtension<MessageT, List<T>> extension) {
1178-
return getExtensionCount((ExtensionLite<MessageT, List<T>>) extension);
1179-
}
1180-
/**
1181-
* Get the value of an extension.
1182-
* <p>TODO: handled by ExtensionLite version
1183-
*/
1184-
@Override
1185-
public final <T> T getExtension(final Extension<MessageT, T> extension) {
1186-
return getExtension((ExtensionLite<MessageT, T>) extension);
1187-
}
1188-
/**
1189-
* Get the value of an extension.
1190-
* <p>TODO: handled by ExtensionLite version
1191-
*/
1192-
@Override
1193-
public final <T> T getExtension(
1194-
final GeneratedExtension<MessageT, T> extension) {
1195-
return getExtension((ExtensionLite<MessageT, T>) extension);
1196-
}
1197-
/**
1198-
* Get one element of a repeated extension.
1199-
* <p>TODO: handled by ExtensionLite version
1200-
*/
1201-
@Override
1202-
public final <T> T getExtension(
1203-
final Extension<MessageT, List<T>> extension, final int index) {
1204-
return getExtension((ExtensionLite<MessageT, List<T>>) extension, index);
1205-
}
1206-
/**
1207-
* Get one element of a repeated extension.
1208-
* <p>TODO: handled by ExtensionLite version
1209-
*/
1210-
@Override
1211-
public final <T> T getExtension(
1212-
final GeneratedExtension<MessageT, List<T>> extension, final int index) {
1213-
return getExtension((ExtensionLite<MessageT, List<T>>) extension, index);
1214-
}
1215-
12161094
/** Called by subclasses to check if all extensions are initialized. */
12171095
protected boolean extensionsAreInitialized() {
12181096
return extensions.isInitialized();
@@ -1601,142 +1479,6 @@ public final <T> BuilderT clearExtension(final ExtensionLite<MessageT, T> extens
16011479
return (BuilderT) this;
16021480
}
16031481

1604-
/**
1605-
* Check if a singular extension is present.
1606-
* <p>TODO: handled by ExtensionLite version
1607-
*/
1608-
@Override
1609-
public final <T> boolean hasExtension(final Extension<MessageT, T> extension) {
1610-
return hasExtension((ExtensionLite<MessageT, T>) extension);
1611-
}
1612-
/**
1613-
* Check if a singular extension is present.
1614-
* <p>TODO: handled by ExtensionLite version
1615-
*/
1616-
@Override
1617-
public final <T> boolean hasExtension(
1618-
final GeneratedExtension<MessageT, T> extension) {
1619-
return hasExtension((ExtensionLite<MessageT, T>) extension);
1620-
}
1621-
/**
1622-
* Get the number of elements in a repeated extension.
1623-
* <p>TODO: handled by ExtensionLite version
1624-
*/
1625-
@Override
1626-
public final <T> int getExtensionCount(
1627-
final Extension<MessageT, List<T>> extension) {
1628-
return getExtensionCount((ExtensionLite<MessageT, List<T>>) extension);
1629-
}
1630-
/**
1631-
* Get the number of elements in a repeated extension.
1632-
* <p>TODO: handled by ExtensionLite version
1633-
*/
1634-
@Override
1635-
public final <T> int getExtensionCount(
1636-
final GeneratedExtension<MessageT, List<T>> extension) {
1637-
return getExtensionCount((ExtensionLite<MessageT, List<T>>) extension);
1638-
}
1639-
/**
1640-
* Get the value of an extension.
1641-
* <p>TODO: handled by ExtensionLite version
1642-
*/
1643-
@Override
1644-
public final <T> T getExtension(final Extension<MessageT, T> extension) {
1645-
return getExtension((ExtensionLite<MessageT, T>) extension);
1646-
}
1647-
/** Get the value of an extension.
1648-
* <p>TODO: handled by ExtensionLite version
1649-
*/
1650-
@Override
1651-
public final <T> T getExtension(
1652-
final GeneratedExtension<MessageT, T> extension) {
1653-
return getExtension((ExtensionLite<MessageT, T>) extension);
1654-
}
1655-
/**
1656-
* Get the value of an extension.
1657-
* <p>TODO: handled by ExtensionLite version
1658-
*/
1659-
@Override
1660-
public final <T> T getExtension(
1661-
final Extension<MessageT, List<T>> extension, final int index) {
1662-
return getExtension((ExtensionLite<MessageT, List<T>>) extension, index);
1663-
}
1664-
/**
1665-
* Get the value of an extension.
1666-
* <p>TODO: handled by ExtensionLite version
1667-
*/
1668-
@Override
1669-
public final <T> T getExtension(
1670-
final GeneratedExtension<MessageT, List<T>> extension, final int index) {
1671-
return getExtension((ExtensionLite<MessageT, List<T>>) extension, index);
1672-
}
1673-
/**
1674-
* Set the value of an extension.
1675-
* <p>TODO: handled by ExtensionLite version
1676-
*/
1677-
public final <T> BuilderT setExtension(
1678-
final Extension<MessageT, T> extension, final T value) {
1679-
return setExtension((ExtensionLite<MessageT, T>) extension, value);
1680-
}
1681-
/**
1682-
* Set the value of an extension.
1683-
* <p>TODO: handled by ExtensionLite version
1684-
*/
1685-
public <T> BuilderT setExtension(
1686-
final GeneratedExtension<MessageT, T> extension, final T value) {
1687-
return setExtension((ExtensionLite<MessageT, T>) extension, value);
1688-
}
1689-
/**
1690-
* Set the value of one element of a repeated extension.
1691-
* <p>TODO: handled by ExtensionLite version
1692-
*/
1693-
public final <T> BuilderT setExtension(
1694-
final Extension<MessageT, List<T>> extension,
1695-
final int index, final T value) {
1696-
return setExtension((ExtensionLite<MessageT, List<T>>) extension, index, value);
1697-
}
1698-
/**
1699-
* Set the value of one element of a repeated extension.
1700-
* <p>TODO: handled by ExtensionLite version
1701-
*/
1702-
public <T> BuilderT setExtension(
1703-
final GeneratedExtension<MessageT, List<T>> extension,
1704-
final int index, final T value) {
1705-
return setExtension((ExtensionLite<MessageT, List<T>>) extension, index, value);
1706-
}
1707-
/**
1708-
* Append a value to a repeated extension.
1709-
* <p>TODO: handled by ExtensionLite version
1710-
*/
1711-
public final <T> BuilderT addExtension(
1712-
final Extension<MessageT, List<T>> extension, final T value) {
1713-
return addExtension((ExtensionLite<MessageT, List<T>>) extension, value);
1714-
}
1715-
/**
1716-
* Append a value to a repeated extension.
1717-
* <p>TODO: handled by ExtensionLite version
1718-
*/
1719-
public <T> BuilderT addExtension(
1720-
final GeneratedExtension<MessageT, List<T>> extension, final T value) {
1721-
return addExtension((ExtensionLite<MessageT, List<T>>) extension, value);
1722-
}
1723-
/**
1724-
* Clear an extension.
1725-
* <p>TODO: handled by ExtensionLite version
1726-
*/
1727-
public final <T> BuilderT clearExtension(
1728-
final Extension<MessageT, T> extension) {
1729-
return clearExtension((ExtensionLite<MessageT, T>) extension);
1730-
}
1731-
/**
1732-
* Clears an extension.
1733-
* <p>TODO: handled by ExtensionLite version
1734-
*/
1735-
public <T> BuilderT clearExtension(
1736-
final GeneratedExtension<MessageT, T> extension) {
1737-
return clearExtension((ExtensionLite<MessageT, T>) extension);
1738-
}
1739-
17401482
/** Called by subclasses to check if all extensions are initialized. */
17411483
protected boolean extensionsAreInitialized() {
17421484
return extensions == null || extensions.isInitialized();

0 commit comments

Comments
 (0)