Skip to content

Commit 6f4a990

Browse files
committed
Migrates some Java test protos using java_features.proto to edition 2024
PiperOrigin-RevId: 788111478
1 parent c51df73 commit 6f4a990

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

bazel/tests/protobuf_test_proto_library.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ def protobuf_test_proto_library(**kwattrs):
1515
if "option_deps" in kwargs and hasattr(native, "proto_library"):
1616
deps = kwargs.pop("deps", [])
1717
option_deps = kwargs.pop("option_deps")
18-
kwargs["deps"] = deps + option_deps
18+
kwargs["deps"] = depset(deps + option_deps).to_list()
1919

2020
proto_library(**kwargs)

java/core/BUILD.bazel

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ load("//bazel:cc_proto_library.bzl", "cc_proto_library")
77
load("//bazel:java_lite_proto_library.bzl", "java_lite_proto_library")
88
load("//bazel:java_proto_library.bzl", "java_proto_library")
99
load("//bazel:proto_library.bzl", "proto_library")
10+
load(
11+
"//bazel/tests:protobuf_test_proto_library.bzl",
12+
"protobuf_test_proto_library",
13+
)
1014
load("//bazel/toolchains:proto_lang_toolchain.bzl", "proto_lang_toolchain")
1115
load("//build_defs:java_opts.bzl", "protobuf_java_export", "protobuf_java_library", "protobuf_versioned_java_library")
1216
load("//conformance:defs.bzl", "conformance_test")
@@ -338,9 +342,12 @@ proto_lang_toolchain(
338342
visibility = ["//visibility:public"],
339343
)
340344

341-
proto_library(
345+
protobuf_test_proto_library(
342346
name = "java_test_protos",
343347
srcs = glob(["src/test/proto/**/*.proto"]),
348+
option_deps = [
349+
"//:java_features_proto",
350+
],
344351
strip_import_prefix = "src/test/proto",
345352
deps = [
346353
"//:any_proto",

java/core/src/test/proto/com/google/protobuf/large_open_enum.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ edition = "2024";
1111

1212
package protobuf_test_messages.edition;
1313

14-
import "google/protobuf/java_features.proto";
14+
import option "google/protobuf/java_features.proto";
1515

1616
option java_package = "com.google.protobuf.large.openenum.edition";
1717
option features.(pb.java).large_enum = true;

java/core/src/test/proto/com/google/protobuf/test_check_utf8.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ edition = "2024";
1212

1313
package proto2_test_check_utf8;
1414

15-
import "google/protobuf/java_features.proto";
15+
import option "google/protobuf/java_features.proto";
1616

1717
option features.utf8_validation = NONE;
1818
option features.(pb.java).utf8_validation = VERIFY;

0 commit comments

Comments
 (0)