Fix fastfile build errors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artwyman
reviewed
Jun 28, 2024
| config.resolve.fallback = { | ||
| fs: false | ||
| }; | ||
| config.resolve.alias = { |
Member
There was a problem hiding this comment.
Can you document what this is required for? Maybe a comment here would be a good place to document the underlying issue.
Collaborator
Author
There was a problem hiding this comment.
added comments
artwyman
approved these changes
Jun 28, 2024
Collaborator
Author
|
The linear issue to track this: https://linear.app/0xparc-pcd/issue/0XP-986/avoid-polyfill-issues-from-fastfile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"@pcd/gpc" has dependency "@pcd/gpcircuits" which in turn depends on fastfile.
"fastfile" uses node modules "fs", "constants" and global "process" (process.browser).
We need to polyfill these in order for it to work in browser.
Otherwise, here is the build error I'm getting when running "yarn build"
This PR (see next.config.js) shows how to fix it in Next.js (uses webpack 5).
snark.js uses rollup, and here is how it does the polyfill.
zupass repo uses esbuild, and it uses the the plugin from "@esbuild-plugins/node-modules-polyfill" to do the polyfill.