Commit 3937878
committed
Pass exemplar timestamp explicitly
This is a bit more expensive when you don't pass it:
```
histogram without exemplars
time: [3.1824 ns 3.2017 ns 3.2235 ns]
change: [-3.6414% +0.1893% +3.1022%] (p = 0.92 > 0.05)
No change in performance detected.
histogram with exemplars (no exemplar passed)
time: [6.2238 ns 6.2487 ns 6.2770 ns]
change: [+7.5129% +8.3245% +9.0265%] (p = 0.00 < 0.05)
Performance has regressed.
histogram with exemplars (some exemplar passed)
time: [70.907 ns 71.667 ns 72.493 ns]
change: [+1.4206% +2.3509% +3.3463%] (p = 0.00 < 0.05)
Performance has regressed.
```
It should amortize as one passes the same timestamp in multiple observations.
Signed-off-by: Ivan Babrou <[email protected]>1 parent 93db069 commit 3937878
4 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
806 | 806 | | |
807 | 807 | | |
808 | 808 | | |
809 | | - | |
| 809 | + | |
810 | 810 | | |
811 | 811 | | |
812 | 812 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
978 | 978 | | |
979 | 979 | | |
980 | 980 | | |
981 | | - | |
| 981 | + | |
982 | 982 | | |
983 | 983 | | |
984 | 984 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
262 | | - | |
| 262 | + | |
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| |||
0 commit comments