Skip to content

Commit 0c1bb5c

Browse files
committed
manifests: remove prometheus.io/scrape annotations
These annotations made sense in pre v1.3.0 Prometheus releases, however, with >=v1.3.0 and the Prometheus Operator these annotations are more confusing then helpful.
1 parent 20f88ee commit 0c1bb5c

File tree

9 files changed

+4
-24
lines changed

9 files changed

+4
-24
lines changed

README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ To tear it all down again, run:
4343
hack/cluster-monitoring/teardown
4444
```
4545

46-
> All services in the manifest still contain the `prometheus.io/scrape = true`
47-
> annotations. It is not used by the Prometheus Operator. They remain for
48-
> pre Prometheus v1.3.0 deployments as in [this example configuration](https://github.com/prometheus/prometheus/blob/6703404cb431f57ca4c5097bc2762438d3c1968e/documentation/examples/prometheus-kubernetes.yml).
49-
5046
## Monitoring custom services
5147

5248
The example manifests in [/manifests/examples/example-app](/manifests/examples/example-app)
@@ -133,4 +129,4 @@ default kubernetes 172.17.4.101:443
133129
kube-system kube-controller-manager-prometheus-discovery 10.2.30.2:10252 1h
134130
kube-system kube-scheduler-prometheus-discovery 10.2.30.4:10251 1h
135131
monitoring etcd-k8s 172.17.4.51:2379 1h
136-
```
132+
```

manifests/etcd/etcd-bootkube-gce.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ metadata:
55
labels:
66
app: etcd
77
etcd: k8s
8-
annotations:
9-
prometheus.io/scrape: 'true'
108
spec:
119
type: ClusterIP
1210
clusterIP: None
@@ -29,4 +27,4 @@ subsets:
2927
ports:
3028
- name: api
3129
port: 2379
32-
protocol: TCP
30+
protocol: TCP

manifests/etcd/etcd-bootkube-vagrant-multi.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ metadata:
55
labels:
66
app: etcd
77
etcd: k8s
8-
annotations:
9-
prometheus.io/scrape: 'true'
108
spec:
119
type: ClusterIP
1210
clusterIP: None
@@ -29,4 +27,4 @@ subsets:
2927
ports:
3028
- name: api
3129
port: 2379
32-
protocol: TCP
30+
protocol: TCP

manifests/examples/example-app/example-app.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ metadata:
44
name: example-app
55
labels:
66
tier: frontend
7-
annotations:
8-
prometheus.io/scrape: 'true'
97
spec:
108
selector:
119
app: example-app

manifests/exporters/kube-state-metrics-svc.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
apiVersion: v1
22
kind: Service
33
metadata:
4-
annotations:
5-
prometheus.io/scrape: 'true'
64
labels:
75
app: kube-state-metrics
86
name: kube-state-metrics

manifests/exporters/node-exporter-svc.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ kind: Service
33
metadata:
44
labels:
55
app: node-exporter
6-
annotations:
7-
prometheus.io/scrape: 'true'
86
name: node-exporter
97
spec:
108
type: ClusterIP

manifests/grafana/grafana-svc.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ metadata:
44
name: grafana
55
labels:
66
app: grafana
7-
annotations:
8-
prometheus.io/scrape: 'true'
97
spec:
108
type: NodePort
119
ports:
@@ -14,4 +12,4 @@ spec:
1412
protocol: TCP
1513
nodePort: 30902
1614
selector:
17-
app: grafana
15+
app: grafana

manifests/k8s/kube-controller-manager-bootkube-vagrant-multi.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ metadata:
44
name: kube-controller-manager-prometheus-discovery
55
labels:
66
k8s-app: kube-controller-manager
7-
annotations:
8-
prometheus.io/scrape: 'true'
97
spec:
108
selector:
119
k8s-app: kube-controller-manager

manifests/k8s/kube-scheduler-bootkube-vagrant-multi.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ metadata:
44
name: kube-scheduler-prometheus-discovery
55
labels:
66
k8s-app: kube-scheduler
7-
annotations:
8-
prometheus.io/scrape: 'true'
97
spec:
108
selector:
119
k8s-app: kube-scheduler

0 commit comments

Comments
 (0)