Change to Gauge

Sticksman · Sticksman · commit 4d68e2df6880 · 2023-07-10T10:42:19.000-07:00
Signed-off-by: Felix Yuan &lt;felix.yuan@reddit.com&gt;
diff --git a/collector/pg_xid.go b/collector/pg_xid.go
@@ -78,12 +78,12 @@ func (PGXidCollector) Update(ctx context.Context, instance *instance, ch chan<-
 
 		ch <- prometheus.MustNewConstMetric(
 			xidCurrent,
-			prometheus.CounterValue,
+			prometheus.GaugeValue,
 			current,
 		)
 		ch <- prometheus.MustNewConstMetric(
 			xidXmin,
-			prometheus.CounterValue,
+			prometheus.GaugeValue,
 			xmin,
 		)
 		ch <- prometheus.MustNewConstMetric(
diff --git a/collector/pg_xid_test.go b/collector/pg_xid_test.go
@@ -50,8 +50,8 @@ func TestPgXidCollector(t *testing.T) {
 		}
 	}()
 	expected := []MetricResult{
-		{labels: labelMap{}, value: 22, metricType: dto.MetricType_COUNTER},
-		{labels: labelMap{}, value: 25, metricType: dto.MetricType_COUNTER},
+		{labels: labelMap{}, value: 22, metricType: dto.MetricType_GAUGE},
+		{labels: labelMap{}, value: 25, metricType: dto.MetricType_GAUGE},
 		{labels: labelMap{}, value: 30, metricType: dto.MetricType_GAUGE},
 	}
 	convey.Convey("Metrics comparison", t, func() {
@@ -92,8 +92,8 @@ func TestPgNanCollector(t *testing.T) {
 		}
 	}()
 	expected := []MetricResult{
-		{labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_COUNTER},
-		{labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_COUNTER},
+		{labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_GAUGE},
+		{labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_GAUGE},
 		{labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_GAUGE},
 	}
 	convey.Convey("Metrics comparison", t, func() {

Original file line number	Diff line number	Diff line change
`@@ -78,12 +78,12 @@ func (PGXidCollector) Update(ctx context.Context, instance *instance, ch chan<-`
`78`	`78`
`79`	`79`	`ch <- prometheus.MustNewConstMetric(`
`80`	`80`	`xidCurrent,`
`81`		`- prometheus.CounterValue,`
	`81`	`+ prometheus.GaugeValue,`
`82`	`82`	`current,`
`83`	`83`	`)`
`84`	`84`	`ch <- prometheus.MustNewConstMetric(`
`85`	`85`	`xidXmin,`
`86`		`- prometheus.CounterValue,`
	`86`	`+ prometheus.GaugeValue,`
`87`	`87`	`xmin,`
`88`	`88`	`)`
`89`	`89`	`ch <- prometheus.MustNewConstMetric(`
Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ func TestPgXidCollector(t *testing.T) {`
`50`	`50`	`}`
`51`	`51`	`}()`
`52`	`52`	`expected := []MetricResult{`
`53`		`- {labels: labelMap{}, value: 22, metricType: dto.MetricType_COUNTER},`
`54`		`- {labels: labelMap{}, value: 25, metricType: dto.MetricType_COUNTER},`
	`53`	`+ {labels: labelMap{}, value: 22, metricType: dto.MetricType_GAUGE},`
	`54`	`+ {labels: labelMap{}, value: 25, metricType: dto.MetricType_GAUGE},`
`55`	`55`	`{labels: labelMap{}, value: 30, metricType: dto.MetricType_GAUGE},`
`56`	`56`	`}`
`57`	`57`	`convey.Convey("Metrics comparison", t, func() {`
`@@ -92,8 +92,8 @@ func TestPgNanCollector(t *testing.T) {`
`92`	`92`	`}`
`93`	`93`	`}()`
`94`	`94`	`expected := []MetricResult{`
`95`		`- {labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_COUNTER},`
`96`		`- {labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_COUNTER},`
	`95`	`+ {labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_GAUGE},`
	`96`	`+ {labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_GAUGE},`
`97`	`97`	`{labels: labelMap{}, value: math.NaN(), metricType: dto.MetricType_GAUGE},`
`98`	`98`	`}`
`99`	`99`	`convey.Convey("Metrics comparison", t, func() {`