Skip to content

Comments

fix: docs workflow remove deprecated actions#290

Merged
prom3theu5 merged 1 commit intomainfrom
fix-docs-release
Feb 15, 2025
Merged

fix: docs workflow remove deprecated actions#290
prom3theu5 merged 1 commit intomainfrom
fix-docs-release

Conversation

@prom3theu5
Copy link
Owner

@prom3theu5 prom3theu5 commented Feb 15, 2025

PR Type

Enhancement, Configuration changes


Description

  • Updated GitHub Actions workflows to use newer versions.

  • Replaced deprecated actions with their latest counterparts.

  • Improved maintainability and compatibility of the documentation workflow.


Changes walkthrough 📝

Relevant files
Configuration changes
docs.yaml
Updated GitHub Actions workflow versions                                 

.github/workflows/docs.yaml

  • Updated actions/checkout to version v4.
  • Updated actions/upload-artifact to version v4.
  • Updated actions/download-artifact to version v4.
  • Updated actions/configure-pages to version v5.
  • Updated actions/upload-pages-artifact to version v3.
  • Updated actions/deploy-pages to version v4.
  • +7/-7     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @prom3theu5 prom3theu5 merged commit e9d0de5 into main Feb 15, 2025
    2 checks passed
    @prom3theu5 prom3theu5 deleted the fix-docs-release branch February 15, 2025 17:03
    @qodo-code-review
    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Pin actions to specific commits

    Add a specific version hash to the GitHub Actions instead of using major version
    tags to prevent potential breaking changes and ensure reproducible builds.

    .github/workflows/docs.yaml [20-21]

     - name: Checkout repository
    -  uses: actions/checkout@v4
    +  uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: Using specific commit hashes instead of major version tags is a security best practice that prevents supply chain attacks and ensures reproducible builds by locking to exact versions. This applies to all GitHub Actions in the workflow.

    Medium

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant