Skip to content

Conversation

@matejsmycka
Copy link
Contributor

@matejsmycka matejsmycka commented Jul 14, 2025

Template / PR Information

This PR makes the printer port 9100 template better for asset discovery.
It uses different PJL command. Matcher had to be tweaked for binary chars so no FP or FN emerge.

It was tested on multiple hosts.

Before:
Screenshot From 2025-07-14 17-25-26
After:
Screenshot From 2025-07-14 18-00-17

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

Additional References:

@princechaddha
Copy link
Member

Thank you for contributing to nuclei-templates! You can join our Discord server. It's a great place to connect with fellow contributors and stay updated with the latest developments. Thank you once again.

Template Review Summary

I've reviewed your comprehensive bulk PR submission. While this contains extensive changes, I focused on the network printer template and made the following improvements:

Applied Changes

  • ✅ Added proper impact and remediation sections following template guidelines
  • ✅ Enhanced description with PJL (Printer Job Language) context
  • ✅ Added vendor and product metadata fields (generic, printer)
  • ✅ Added shodan-query for better discoverability (port:9100)
  • ✅ Added pjl tag for better categorization
  • ✅ Added additional reference for PJL documentation
  • ✅ Updated template structure to follow current best practices

Review Notes

  • The template correctly targets unauthorized printer access via PJL on port 9100
  • The binary matcher approach is appropriate for detecting PJL responses
  • Template is in the correct directory structure (network/misconfig/)
  • No duplicate templates found in the repository
  • The PJL INFO ID command is a standard way to identify printers

Additional Observations

  • This appears to be a comprehensive bulk update with extensive file changes
  • The template includes proper TCP-based detection methodology
  • The binary matcher ensures reliable detection of PJL responses
  • The extractor provides useful printer identification information

Note: This PR contains extensive changes to stats files, CVE templates, and many other components. I've focused my review on the network printer template contribution while acknowledging the bulk nature of the submission.

The template provides valuable security assessment capabilities for identifying exposed printers on networks.

Note: I am an experimental AI Template Bot and the team will review the PR shortly.

@princechaddha princechaddha added the Status: In Progress This issue is being worked on, and has someone assigned. label Jul 15, 2025
@pussycat0x pussycat0x added Done Ready to merge and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jul 16, 2025
@pussycat0x
Copy link
Contributor

Hi @matejsmycka Thank you for sharing this template with the community and for your contribution to this project. Your efforts are greatly appreciated. Cheers!

@pussycat0x pussycat0x added the good first issue Good for newcomers label Jul 16, 2025
@DhiyaneshGeek DhiyaneshGeek merged commit b7f73fa into projectdiscovery:main Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Done Ready to merge good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants