Fix broken path to reference file to remedy 404 errors… #11987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w path of the "noseyparker" repo. Simple find and replace operation that made the same edit to all 60 files.
…arker" (after verifying that the URL is valid)
|
Thanks so much for your contribution @adaminfinitum ! :) As a token of appreciation for your valuable contribution, you can grab some cool PD Stickers from here http://nux.gg/stickers. We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments! |
|
Thanks for a lot for fixing the template reference Links & contributing to the template project 😄 |
pussycat0x
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and reflect new paths of the "noseyparker" repo. Simple find and replace operation that made the same edit to all 60 files.
(plus added reference documentation directly from "noseyparker" to many additional files...no code was changed in any of these commits.)
Template / PR Information
First Commit
This is effectively an edit to supporting documentation.
I was working on a project I have running locally and was looking at this file:
http/exposures/tokens/google/google-oauth-prefixed.yamlWhen I went to find more information by following the link listed under 'References', It led me to a 404.
I browsed the current 'praetorian-inc/noseyparker' repo and realized the directory structure and files paths had changed so I did a search and found 60 instances of that string in the files, I spot checked another one to make sure it was consistent and then I did a 'find' for:
praetorian-inc/noseyparker/blob/main/data/default/rules/And 'replace' it with:
praetorian-inc/noseyparker/blob/main/crates/noseyparker/data/default/builtin/rules/Second and Third Commits
These are just simply fixing, editing and mostly copying additional reference links from "noseyparker"
No code was changed in any of these 3 commits, and everything looked correct under syntax highlighting
Not all have been tested yet as I am not running all of them right now, but I have no reason to think anything won't work.
Template Validation
I've validated this template locally?
Additional Details (leave it blank if not applicable)
Additional References: