Skip to content

Conversation

@geeknik
Copy link
Contributor

@geeknik geeknik commented Oct 8, 2024

Template / PR Information

  • Obliterating false negatives.

Template Validation

I've validated this template locally?

  • YES
  • NO

Odin, bearer of wisdom, see this humble change.
May the lines of my work be etched in Yggdrasil’s bark,
Clear as runes, unbroken, without fear or flaw.
Guide my fingers, that each commit may weave fate
Into a future our kin can honor,
As we do our part in the forging of code.
Skål!

@GeorginaReeder
Copy link

Beautiful, poetic :D thanks so much as always for your contribution @geeknik !

@geeknik
Copy link
Contributor Author

geeknik commented Oct 9, 2024

Thank you @GeorginaReeder, I always appreciate your kind words. 🫶🏻
Now we should chat about your automation classifying this as a weak matcher haha. 🙄
I tested this new version on multiple hosts that the old version missed. This one is better, pinky promise. 🤙🏻

Obliterating false negatives.
@DhiyaneshGeek
Copy link
Member

Hi @geeknik

i have updated the dsl format to refrain from false positive

Let me know if these changes looks good , thanks

@geeknik
Copy link
Contributor Author

geeknik commented Nov 6, 2024

LGTM!

Let me know if these changes looks good , thanks

@DhiyaneshGeek DhiyaneshGeek added Status: On Hold Similar to blocked, but is assigned to someone and removed Done Ready to merge labels Nov 7, 2024
@ehsandeep ehsandeep removed the Status: On Hold Similar to blocked, but is assigned to someone label Dec 30, 2024
@ehsandeep ehsandeep merged commit c210365 into projectdiscovery:main Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants