fixing test

Author: Mzack9999

fastdialer/dialer.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"crypto/tls"
+	"encoding/gob"
 	"encoding/json"
 	"fmt"
 	"net"
@@ -15,6 +16,7 @@ import (
 
 	"github.com/Mzack9999/gcache"
 	gounit "github.com/docker/go-units"
+	"github.com/miekg/dns"
 	"github.com/projectdiscovery/hmap/store/hybrid"
 	"github.com/projectdiscovery/networkpolicy"
 	"github.com/projectdiscovery/retryabledns"
@@ -50,6 +52,25 @@ func init() {
 	}
 	MaxDNSCacheSize = maxDnsCacheSize
 	MaxDNSItems = env.GetEnvOrDefault("MAX_DNS_ITEMS", 1024)
+
+	// Register DNS types with gob encoder
+	gob.Register(&dns.SOA{})
+	gob.Register(&dns.A{})
+	gob.Register(&dns.AAAA{})
+	gob.Register(&dns.CNAME{})
+	gob.Register(&dns.MX{})
+	gob.Register(&dns.NS{})
+	gob.Register(&dns.PTR{})
+	gob.Register(&dns.SRV{})
+	gob.Register(&dns.TXT{})
+	gob.Register(&dns.CAA{})
+	gob.Register(&dns.DNSKEY{})
+	gob.Register(&dns.DS{})
+	gob.Register(&dns.NSEC{})
+	gob.Register(&dns.NSEC3{})
+	gob.Register(&dns.RRSIG{})
+	gob.Register(&dns.TLSA{})
+	gob.Register(&dns.OPT{})
 }
 
 // Dialer structure containing data information

fastdialer/dialer_private.go

@@ -114,7 +114,6 @@ func (d *Dialer) dial(ctx context.Context, opts *dialOptions) (conn net.Conn, er
 			cacheData, err, _ := d.resolutionsGroup.Do(hostname, func() (interface{}, error) {
 				return d.GetDNSData(hostname)
 			})
-
 			if cacheData == nil {
 				return nil, ResolveHostError
 			}

fastdialer/dialer_test.go

@@ -20,7 +20,7 @@ func TestDialer(t *testing.T) {
 	testDialer(t, options)
 
 	// disk
-	options.CacheType = Hybrid
+	options.CacheType = Disk
 	options.CacheMemoryMaxItems = 100
 	testDialer(t, options)
 
@@ -32,25 +32,28 @@ func testDialer(t *testing.T, options Options) {
 	fd, err := NewDialer(options)
 	if err != nil {
 		t.Errorf("couldn't create fastdialer instance: %s", err)
+		return
 	}
+	defer fd.Close()
 
 	// valid resolution + cache
 	ctx := context.Background()
 	conn, err := fd.Dial(ctx, "tcp", "www.projectdiscovery.io:80")
 	if err != nil || conn == nil {
 		t.Errorf("couldn't connect to target: %s", err)
+		return
 	}
 	if err := conn.Close(); err != nil {
 		t.Errorf("failed to close connection: %s", err)
+		return
 	}
 	// retrieve cached data
 	data, err := fd.GetDNSData("www.projectdiscovery.io")
 	if err != nil || data == nil {
 		t.Errorf("couldn't retrieve dns data: %s", err)
+		return
 	}
 	if len(data.A) == 0 {
 		t.Error("no A results found")
 	}
-	// cleanup
-	fd.Close()
 }

fastdialer/options.go

@@ -76,7 +76,7 @@ var DefaultOptions = Options{
 	MaxRetries:                      5,
 	HostsFile:                       true,
 	ResolversFile:                   true,
-	CacheType:                       Disk,
+	CacheType:                       Memory,
 	DialerTimeout:                   10 * time.Second,
 	DialerKeepAlive:                 10 * time.Second,
 	MaxTemporaryErrors:              30,

go.mod

@@ -6,6 +6,7 @@ require (
 	github.com/Mzack9999/gcache v0.0.0-20230410081825-519e28eab057
 	github.com/dimchansky/utfbom v1.1.1
 	github.com/docker/go-units v0.5.0
+	github.com/miekg/dns v1.1.62
 	github.com/projectdiscovery/goleak v0.0.0-20240729222606-a7d18edc33f8
 	github.com/projectdiscovery/hmap v0.0.92
 	github.com/projectdiscovery/networkpolicy v0.1.20
@@ -34,7 +35,6 @@ require (
 	github.com/logrusorgru/aurora/v4 v4.0.0 // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/microcosm-cc/bluemonday v1.0.27 // indirect
-	github.com/miekg/dns v1.1.62 // indirect
 	github.com/onsi/gomega v1.27.6 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect