Cleanup: Use Envoy contains for header routing #5585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5572 Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
added
the
release-note/none-required
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5585 +/- ##
==========================================
- Coverage 78.55% 78.54% -0.01%
==========================================
Files 138 138
Lines 19044 19036 -8
==========================================
- Hits 14960 14952 -8
Misses 3801 3801
Partials 283 283
|
davinci26
requested review from
stevesloka and
sunjayBhatia
and removed request for
a team
Contributor
Author
|
I marked as release-note/none-required to make the CI happy, but happy to add one if you think it is needed |
skriss
approved these changes
Jul 27, 2023
Member
skriss
left a comment
skriss
left a comment
There was a problem hiding this comment.
LGTM, did some ad-hoc testing and all behavior seems to stay consistent
Member
|
Not sure why gateway-conformance is giving so much trouble on this one; I was able to run successfully locally. Will give it one more try. |
clayton-gonsalves
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5572