Skip to content

Commit 91e5942

Browse files
committed
tiny cleanup
Signed-off-by: Sunjay Bhatia <[email protected]>
1 parent 413e476 commit 91e5942

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

internal/dag/accessors_test.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,9 @@ func TestGetServiceClusters(t *testing.T) {
291291
},
292292
},
293293
}
294+
// We should only get one cluster since the other is for an ExternalName
295+
// service.
296+
assert.Len(t, d.GetServiceClusters(), 1)
294297

295298
dagWithMirror := &DAG{
296299
Listeners: map[string]*Listener{
@@ -300,7 +303,6 @@ func TestGetServiceClusters(t *testing.T) {
300303
Routes: map[string]*Route{
301304
"foo": {
302305
Clusters: []*Cluster{
303-
{Upstream: &Service{ExternalName: "bar.com"}},
304306
{Upstream: &Service{}},
305307
},
306308
MirrorPolicies: []*MirrorPolicy{
@@ -317,10 +319,6 @@ func TestGetServiceClusters(t *testing.T) {
317319
},
318320
},
319321
}
320-
// We should only get one cluster since the other is for an ExternalName
321-
// service.
322-
assert.Len(t, d.GetServiceClusters(), 1)
323-
324-
// We should get one two clusters since we have mirrorPolicies.
322+
// We should get two clusters since we have mirrorPolicies.
325323
assert.Len(t, dagWithMirror.GetServiceClusters(), 2)
326324
}

0 commit comments

Comments
 (0)