Fix oauth2 error handle not return immediately (go-gitea#32514)

lunny · earl-warren · commit 6ac04b8c7dce · 2024-11-17T11:44:09.000+01:00
(cherry picked from commit 4121f95)
diff --git a/routers/web/auth/oauth.go b/routers/web/auth/oauth.go
@@ -1013,6 +1013,8 @@ func SignInOAuthCallback(ctx *context.Context) {
 		}
 		if err, ok := err.(*go_oauth2.RetrieveError); ok {
 			ctx.Flash.Error("OAuth2 RetrieveError: "+err.Error(), true)
+			ctx.Redirect(setting.AppSubURL + "/user/login")
+			return
 		}
 		ctx.ServerError("UserSignIn", err)
 		return

Original file line number	Diff line number	Diff line change
`@@ -1013,6 +1013,8 @@ func SignInOAuthCallback(ctx *context.Context) {`
`1013`	`1013`	`}`
`1014`	`1014`	`if err, ok := err.(*go_oauth2.RetrieveError); ok {`
`1015`	`1015`	`ctx.Flash.Error("OAuth2 RetrieveError: "+err.Error(), true)`
	`1016`	`+ ctx.Redirect(setting.AppSubURL + "/user/login")`
	`1017`	`+ return`
`1016`	`1018`	`}`
`1017`	`1019`	`ctx.ServerError("UserSignIn", err)`
`1018`	`1020`	`return`