Add BLS12-381 and JubJub #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
https://github.com/zkcrypto/group/pull/48/files will unblock this |
Contributor
|
Bls12_381 is now being added in PR #87, can we close this PR? |
Contributor
|
Closing as Bls has already been given support for this crate in #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Includes BLS12-381 and JubJub curve to halo2curves.
The implementation of BLS12-381 uses the library's macros to derive the curve implementations (
new_curve_impl). The rest of the code is taken fromzkcrypto/bls12-381, with the notable exception of the endianness of serialisation ofFpelements.zkcrypto's implementation uses big endian, but in order to be compatible with the curve macros, we had to change it to little endian.Couldn't use the
field_commonmacro, as it is aimed for 32 bytes prime fields. Would be happy to generalise the macro if that is something of interest.The implementation of JubJub is taken from
zkcrypto/jubjub, as thenew_curve_implcannot be used for elliptic curves in edwards form.