From 7ef84598608b76a16a3dcd4d54664320a4807d59 Mon Sep 17 00:00:00 2001 From: Li Zhou Date: Tue, 26 Aug 2025 16:22:02 +0100 Subject: [PATCH 1/2] Add property release.autoPublish to pom.xml (#25880) This PR 1. Added the property `release.autoPublish` so that it can be controled by github action 2. Removed the deprecated `nexus-staging-maven-plugin` As part of the fix for PR https://github.com/prestodb/presto/pull/25879 Release 0.294 N/A - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ``` == NO RELEASE NOTE == ``` --- pom.xml | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/pom.xml b/pom.xml index 52ed78bd8ad51..32dad6527ab22 100644 --- a/pom.xml +++ b/pom.xml @@ -61,7 +61,6 @@ 8.11.3 3.8.0 1.13.1 - 1.6.8 9.7.1 1.9.17 313 @@ -108,6 +107,7 @@ -missing 1.17.1 2.32.9 + true @@ -2791,18 +2791,6 @@ - - org.sonatype.plugins - nexus-staging-maven-plugin - ${dep.nexus-staging-plugin.version} - - - ossrh - https://oss.sonatype.org/ - - - com.facebook.presto presto-maven-plugin @@ -3021,7 +3009,7 @@ true ossrh - true + ${release.autoPublish} validated From 762c24298a3963ac0baf29eb9b3c1be6656cbb91 Mon Sep 17 00:00:00 2001 From: Li Zhou Date: Wed, 27 Aug 2025 18:44:56 +0100 Subject: [PATCH 2/2] Exclude executable jars when publishing maven artifacts (#25900) After migrated the central publishing, the executable jar(with shell script) files can not be published because of the maven repository limitation This PR exclude the jars with shell script by adding a profile `executable-jar`, and add a dummy file so that the java doc can be generated for publishing Release 0.294 Manually tested image - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ``` == NO RELEASE NOTE == ``` --- presto-benchmark-driver/pom.xml | 94 ++++++++++-------- .../presto/benchto/benchmarks/Dummy.java | 21 ++++ presto-cli/pom.xml | 98 +++++++++++-------- presto-testing-server-launcher/pom.xml | 95 ++++++++++-------- 4 files changed, 181 insertions(+), 127 deletions(-) create mode 100644 presto-benchto-benchmarks/src/main/java/com/facebook/presto/benchto/benchmarks/Dummy.java diff --git a/presto-benchmark-driver/pom.xml b/presto-benchmark-driver/pom.xml index 1ea86335581be..76725407eb1d5 100644 --- a/presto-benchmark-driver/pom.xml +++ b/presto-benchmark-driver/pom.xml @@ -93,48 +93,58 @@ - - - - org.apache.maven.plugins - maven-shade-plugin - - - package - - shade - + + + executable-jar + + + !skipExecutableJar + + + + + + org.apache.maven.plugins + maven-shade-plugin + + + package + + shade + + + true + executable + + + + ${main-class} + + + + + + + + + + org.skife.maven + really-executable-jar-maven-plugin - true - executable - - - - ${main-class} - - - + -Xmx1G + executable - - - - - - org.skife.maven - really-executable-jar-maven-plugin - - -Xmx1G - executable - - - - package - - really-executable-jar - - - - - - + + + package + + really-executable-jar + + + + + + + + diff --git a/presto-benchto-benchmarks/src/main/java/com/facebook/presto/benchto/benchmarks/Dummy.java b/presto-benchto-benchmarks/src/main/java/com/facebook/presto/benchto/benchmarks/Dummy.java new file mode 100644 index 0000000000000..e5bc3b155b6b8 --- /dev/null +++ b/presto-benchto-benchmarks/src/main/java/com/facebook/presto/benchto/benchmarks/Dummy.java @@ -0,0 +1,21 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.facebook.presto.benchto.benchmarks; + +/** + * This class exists to force the creation of a jar for the presto-benchto-benchmarks module. This is needed to deploy the presto-benchto-benchmarks module to nexus. + */ +public class Dummy +{ +} diff --git a/presto-cli/pom.xml b/presto-cli/pom.xml index 8d2bcb99858b6..c2298b07486c2 100644 --- a/presto-cli/pom.xml +++ b/presto-cli/pom.xml @@ -130,48 +130,6 @@ - - org.apache.maven.plugins - maven-shade-plugin - - - package - - shade - - - true - executable - false - - - - ${main-class} - - - - - - - - - - org.skife.maven - really-executable-jar-maven-plugin - - -Xmx1G - executable - - - - package - - really-executable-jar - - - - - org.basepom.maven duplicate-finder-maven-plugin @@ -195,4 +153,60 @@ + + + + executable-jar + + + !skipExecutableJar + + + + + + org.apache.maven.plugins + maven-shade-plugin + + + package + + shade + + + true + executable + false + + + + ${main-class} + + + + + + + + + + org.skife.maven + really-executable-jar-maven-plugin + + -Xmx1G + executable + + + + package + + really-executable-jar + + + + + + + + diff --git a/presto-testing-server-launcher/pom.xml b/presto-testing-server-launcher/pom.xml index 67acac907c506..dc51f0626e6a0 100644 --- a/presto-testing-server-launcher/pom.xml +++ b/presto-testing-server-launcher/pom.xml @@ -45,49 +45,58 @@ - - - - org.apache.maven.plugins - maven-shade-plugin - - - package - - shade - + + + executable-jar + + + !skipExecutableJar + + + + + + org.apache.maven.plugins + maven-shade-plugin + + + package + + shade + + + true + executable + + + + ${main-class} + + + + + + + + + + org.skife.maven + really-executable-jar-maven-plugin - true - executable - - - - ${main-class} - - - + -Xmx1G + executable - - - - - - org.skife.maven - really-executable-jar-maven-plugin - - -Xmx1G - executable - - - - package - - really-executable-jar - - - - - - - + + + package + + really-executable-jar + + + + + + + +