check for vxlan mapping before removing vlan (sonic-net#2388)

* [Vxlan] check for vxlan mapping before removing vlan

Author: ITJamie

config/vlan.py

@@ -72,6 +72,10 @@ def del_vlan(db, vid):
 
         if keys: # TODO: MISSING CONSTRAINT IN YANG MODEL
             ctx.fail("VLAN ID {} can not be removed. First remove all members assigned to this VLAN.".format(vid))
+        vxlan_table = db.cfgdb.get_table('VXLAN_TUNNEL_MAP')
+        for vxmap_key, vxmap_data in vxlan_table.items():
+            if vxmap_data['vlan'] == 'Vlan{}'.format(vid):
+                ctx.fail("vlan: {} can not be removed. First remove vxlan mapping '{}' assigned to VLAN".format(vid, '|'.join(vxmap_key)) )
     else:    
         config_db = ValidatedConfigDBConnector(db.cfgdb)
 

tests/vlan_test.py

@@ -311,6 +311,30 @@ def test_config_vlan_add_rif_portchannel_member(self):
         assert result.exit_code != 0
         assert "Error: PortChannel0001 is a router interface!" in result.output
 
+    def test_config_vlan_with_vxlanmap_del_vlan(self):
+        runner = CliRunner()
+        db = Db()
+        obj = {'config_db': db.cfgdb}
+
+        # create vlan
+        result = runner.invoke(config.config.commands["vlan"].commands["add"], ["1027"], obj=db)
+        print(result.exit_code)
+        print(result.output)
+        assert result.exit_code == 0
+
+        # create vxlan map
+        result = runner.invoke(config.config.commands["vxlan"].commands["map"].commands["add"], ["vtep1", "1027", "11027"], obj=db)
+        print(result.exit_code)
+        print(result.output)
+        assert result.exit_code == 0
+
+        # attempt to del vlan with vxlan map, should fail
+        result = runner.invoke(config.config.commands["vlan"].commands["del"], ["1027"], obj=db)
+        print(result.exit_code)
+        print(result.output)
+        assert result.exit_code != 0
+        assert "Error: vlan: 1027 can not be removed. First remove vxlan mapping" in result.output
+
     def test_config_vlan_del_vlan(self):
         runner = CliRunner()
         db = Db()