Skip to content

Commit 26c62d1

Browse files
authored
GDV-41: [CPP] clang-format to validate/fix style (apache#52)
- added target "make stylecheck" to check style - added target "make stylefix" to check style - fixed README.md - fixed ci script - used stylefix to fix all existing style violations
1 parent 9a38b88 commit 26c62d1

82 files changed

Lines changed: 1218 additions & 8131 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
Language: Cpp
3+
BasedOnStyle: Google
4+
ColumnLimit: 90
5+
...
6+

cpp/src/gandiva/src/cpp/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,5 @@ enable_testing()
4848
add_subdirectory(src)
4949
add_subdirectory(integ)
5050

51-
add_lint() # "make lint" target
51+
add_stylecheck() # "make stylecheck" target
52+
add_stylefix() # "make stylefix" target

cpp/src/gandiva/src/cpp/README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,14 @@ We follow the [google cpp code style][3]. To validate compliance,
5353

5454
```shell
5555
cd debug
56-
make lint
56+
make stylecheck
57+
```
58+
59+
## Fixing code style
60+
61+
```shell
62+
cd debug
63+
make stylefix
5764
```
5865

5966
[1]: https://brew.sh/

0 commit comments

Comments
 (0)