Add coverage detection on WindowsLocalCommandExecutor (#3979)

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>

Author: olperr1

computation-local/src/main/java/com/powsybl/computation/local/WindowsLocalCommandExecutor.java

@@ -101,7 +101,7 @@ private static String escapeCmdEnvValue(String value) {
             .replace("\r", "");
     }
 
-    private static String escapeCmdArg(String arg) {
+    protected static String escapeCmdArg(String arg) {
         // Double any trailing backslashes before the closing quote
         int trailingBackslashes = 0;
         for (int i = arg.length() - 1; i >= 0 && arg.charAt(i) == '\\'; i--) {

computation-local/src/test/java/com/powsybl/computation/local/LocalCommandExecutorSecurityTest.java

@@ -144,8 +144,9 @@ void testCommandInjectionInParametersOnWindows() {
         assertFalse(Files.exists(pwndFileEnvVariable), String.format("[!] Command injection confirmed: %s created", pwndFileEnvVariable));
     }
 
+    // The following test can be executed on every OS.
+    // It asserts that no system command is run when invalid environment variable names are detected.
     @Test
-    @EnabledOnOs(OS.WINDOWS)
     void testCommandInjectionViaEnvVarNameOnWindows() {
         // 7. Injection via environment variable name: names cannot be safely escaped,
         //    so the executor must reject invalid names outright.
@@ -165,8 +166,9 @@ void testCommandInjectionViaEnvVarNameOnWindows() {
         assertFalse(Files.exists(pwndFileEnvVarName), String.format("[!] Command injection confirmed: %s created", pwndFileEnvVarName));
     }
 
+    // The following test can be executed on every OS.
+    // It asserts that no system command is run when an invalid program name is detected.
     @Test
-    @EnabledOnOs(OS.WINDOWS)
     void testCommandInjectionViaProgramNameOnWindows() {
         // 8. Injection via program name containing a double quote.
         //    The executor must reject program names with quotes rather than pass them raw.
@@ -192,4 +194,14 @@ void testCommandInjectionViaProgramNameOnWindows() {
         assertEquals("Program name must not contain spaces", exception2.getMessage());
         assertFalse(Files.exists(pwndFileEnvVarName), String.format("[!] Command injection confirmed: %s created", pwndFileEnvVarName));
     }
+
+    @Test
+    void testEscapeCmdArgOnWindows() {
+        assertEquals("abc\\\\\\\\", WindowsLocalCommandExecutor.escapeCmdArg("abc\\\\"));
+        assertEquals("a^^b", WindowsLocalCommandExecutor.escapeCmdArg("a^b"));
+        assertEquals("a^%", WindowsLocalCommandExecutor.escapeCmdArg("a%"));
+        assertEquals("^!ab", WindowsLocalCommandExecutor.escapeCmdArg("!ab"));
+        assertEquals("a\"\"b", WindowsLocalCommandExecutor.escapeCmdArg("a\"b"));
+        assertEquals("ab", WindowsLocalCommandExecutor.escapeCmdArg("a\n\rb"));
+    }
 }