fix: return early if creating the resource failed. (#285)

Author: benubois

fixtures/nock/mercury-test.js

@@ -32,14 +32,14 @@ const Mercury = {
 
     const $ = await Resource.create(url, html, parsedUrl);
 
-    const Extractor = getExtractor(url, parsedUrl, $);
-    // console.log(`Using extractor for ${Extractor.domain}`);
-
     // If we found an error creating the resource, return that error
     if ($.failed) {
       return $;
     }
 
+    const Extractor = getExtractor(url, parsedUrl, $);
+    // console.log(`Using extractor for ${Extractor.domain}`);
+
     // if html still has not been set (i.e., url passed to Mercury.parse),
     // set html from the response of Resource.create
     if (!html) {

src/mercury.js

@@ -33,6 +33,14 @@ describe('Mercury', () => {
       assert.equal(result.content.indexOf('score="') === -1, true);
     });
 
+    it('returns an error on non-2xx responses', async () => {
+      const error = await Mercury.parse(
+        'https://www.thekitchn.com/instant-pot-chicken-pesto-pasta-eating-instantly-267141'
+      );
+
+      assert.equal(error, Errors.badUrl);
+    });
+
     it('does blogger', async () => {
       const result = await Mercury.parse(
         'https://googleblog.blogspot.com/2016/08/onhub-turns-one-today.html'