Skip to content

Commit 7709d69

Browse files
janetleekimadampash
authored andcommitted
feat: npr parser (#86)
* feat: npr parser Lead image appears in preview, but the test fails for some reason. AssertionError: null == 'https://media.npr.org/assets/img/2016/12/15/gettyimages-540681598_wide- 8b160732b96c083dc115134c3c019f3ac73586ba.jpg?s=1400' Looks okay otherwise. * feat: transformed figures/figcaptions, improved date_published and addressed NPR's bad image metadata
1 parent 8a82f2c commit 7709d69

4 files changed

Lines changed: 139 additions & 0 deletions

File tree

fixtures/www.npr.org/1481842125199.html

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

src/extractors/custom/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export * from './www.theguardian.com';
2929
export * from './www.sbnation.com';
3030
export * from './www.bloomberg.com';
3131
export * from './www.bustle.com';
32+
export * from './www.npr.org';
3233
export * from './www.recode.net';
3334
export * from './qz.com';
3435
export * from './www.dmagazine.com';
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
export const WwwNprOrgExtractor = {
2+
domain: 'www.npr.org',
3+
4+
title: {
5+
selectors: [
6+
'h1',
7+
'.storytitle',
8+
],
9+
},
10+
11+
author: {
12+
selectors: [
13+
'p.byline__name.byline__name--block',
14+
],
15+
},
16+
17+
date_published: {
18+
selectors: [
19+
['.dateblock time[datetime]', 'datetime'],
20+
['meta[name="date"]', 'value'],
21+
],
22+
},
23+
24+
lead_image_url: {
25+
selectors: [
26+
['meta[name="og:image"]', 'value'],
27+
['meta[name="twitter:image:src"]', 'value'],
28+
],
29+
},
30+
31+
content: {
32+
selectors: [
33+
'.storytext',
34+
],
35+
36+
// Is there anything in the content you selected that needs transformed
37+
// before it's consumable content? E.g., unusual lazy loaded images
38+
transforms: {
39+
'.bucketwrap.image': 'figure',
40+
'.bucketwrap.image .credit-caption': 'figcaption',
41+
},
42+
43+
// Is there anything that is in the result that shouldn't be?
44+
// The clean selectors will remove anything that matches from
45+
// the result
46+
clean: [
47+
'div.enlarge_measure',
48+
],
49+
},
50+
};
Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
import assert from 'assert';
2+
import fs from 'fs';
3+
import URL from 'url';
4+
import cheerio from 'cheerio';
5+
6+
import Mercury from 'mercury';
7+
import getExtractor from 'extractors/get-extractor';
8+
import { excerptContent } from 'utils/text';
9+
10+
describe('WwwNprOrgExtractor', () => {
11+
describe('initial test case', () => {
12+
let result;
13+
let url;
14+
beforeAll(() => {
15+
url =
16+
'http://www.npr.org/sections/thetwo-way/2016/12/15/505723552/jury-finds-dylann-roof-guilty-in-s-c-church-shooting';
17+
const html =
18+
fs.readFileSync('./fixtures/www.npr.org/1481842125199.html');
19+
result =
20+
Mercury.parse(url, html, { fallback: false });
21+
});
22+
23+
it('is selected properly', () => {
24+
// This test should be passing by default.
25+
// It sanity checks that the correct parser
26+
// is being selected for URLs from this domain
27+
const extractor = getExtractor(url);
28+
assert.equal(extractor.domain, URL.parse(url).hostname);
29+
});
30+
31+
it('returns the title', async () => {
32+
// To pass this test, fill out the title selector
33+
// in ./src/extractors/custom/www.npr.org/index.js.
34+
const { title } = await result;
35+
36+
// Update these values with the expected values from
37+
// the article.
38+
assert.equal(title, 'Jury Finds Dylann Roof Guilty In S.C. Church Shooting');
39+
});
40+
41+
it('returns the author', async () => {
42+
// To pass this test, fill out the author selector
43+
// in ./src/extractors/custom/www.npr.org/index.js.
44+
const { author } = await result;
45+
46+
// Update these values with the expected values from
47+
// the article.
48+
assert.equal(author, 'Rebecca Hersher');
49+
});
50+
51+
it('returns the date_published', async () => {
52+
// To pass this test, fill out the date_published selector
53+
// in ./src/extractors/custom/www.npr.org/index.js.
54+
const { date_published } = await result;
55+
56+
// Update these values with the expected values from
57+
// the article.
58+
assert.equal(date_published, '2016-12-15T20:33:00.000Z');
59+
});
60+
61+
it('returns the lead_image_url', async () => {
62+
// To pass this test, fill out the lead_image_url selector
63+
// in ./src/extractors/custom/www.npr.org/index.js.
64+
const { lead_image_url } = await result;
65+
66+
// Update these values with the expected values from
67+
// the article.
68+
assert.equal(lead_image_url, 'https://media.npr.org/assets/img/2016/12/15/ap_16342669033405_wide-e76ba54ba052acbbbe4b9bd73bd429e8d5ca58c7.jpg?s=1400');
69+
});
70+
71+
it('returns the content', async () => {
72+
// To pass this test, fill out the content selector
73+
// in ./src/extractors/custom/www.npr.org/index.js.
74+
// You may also want to make use of the clean and transform
75+
// options.
76+
const { content } = await result;
77+
78+
const $ = cheerio.load(content || '');
79+
80+
const first13 = excerptContent($('*').first().text(), 13);
81+
82+
// Update these values with the expected values from
83+
// the article.
84+
assert.equal(first13, 'Dylann Roof is escorted from the Shelby Police Department in Shelby, N.C., on');
85+
});
86+
});
87+
});

0 commit comments

Comments
 (0)