Skip to content

Commit aa43a60

Browse files
janetleekimpapa-zakari
authored andcommitted
feat: cnbc parser (#96)
Should be good to go!
1 parent cd245f7 commit aa43a60

4 files changed

Lines changed: 135 additions & 0 deletions

File tree

fixtures/www.cnbc.com/1482251664848.html

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

src/extractors/custom/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export * from './www.sbnation.com';
3030
export * from './www.bloomberg.com';
3131
export * from './www.bustle.com';
3232
export * from './www.vox.com';
33+
export * from './www.cnbc.com';
3334
export * from './www.popsugar.com';
3435
export * from './observer.com';
3536
export * from './people.com';
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
export const WwwCnbcComExtractor = {
2+
domain: 'www.cnbc.com',
3+
4+
title: {
5+
selectors: [
6+
'h1.title',
7+
],
8+
},
9+
10+
author: {
11+
selectors: [
12+
['meta[name="author"]', 'value'],
13+
],
14+
},
15+
16+
date_published: {
17+
selectors: [
18+
['meta[name="article:published_time"]', 'value'],
19+
],
20+
},
21+
22+
lead_image_url: {
23+
selectors: [
24+
['meta[name="og:image"]', 'value'],
25+
],
26+
},
27+
28+
content: {
29+
selectors: [
30+
'div#article_body.content',
31+
'div.story',
32+
],
33+
34+
// Is there anything in the content you selected that needs transformed
35+
// before it's consumable content? E.g., unusual lazy loaded images
36+
transforms: {
37+
},
38+
39+
// Is there anything that is in the result that shouldn't be?
40+
// The clean selectors will remove anything that matches from
41+
// the result
42+
clean: [
43+
44+
],
45+
},
46+
};
Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
import assert from 'assert';
2+
import fs from 'fs';
3+
import URL from 'url';
4+
import cheerio from 'cheerio';
5+
6+
import Mercury from 'mercury';
7+
import getExtractor from 'extractors/get-extractor';
8+
import { excerptContent } from 'utils/text';
9+
10+
describe('WwwCnbcComExtractor', () => {
11+
describe('initial test case', () => {
12+
let result;
13+
let url;
14+
beforeAll(() => {
15+
url =
16+
'http://www.cnbc.com/2016/12/20/coals-us-stronghold-is-losing-steam-even-as-trump-aims-for-a-revival.html';
17+
const html =
18+
fs.readFileSync('./fixtures/www.cnbc.com/1482251664848.html');
19+
result =
20+
Mercury.parse(url, html, { fallback: false });
21+
});
22+
23+
it('is selected properly', () => {
24+
// This test should be passing by default.
25+
// It sanity checks that the correct parser
26+
// is being selected for URLs from this domain
27+
const extractor = getExtractor(url);
28+
assert.equal(extractor.domain, URL.parse(url).hostname);
29+
});
30+
31+
it('returns the title', async () => {
32+
// To pass this test, fill out the title selector
33+
// in ./src/extractors/custom/www.cnbc.com/index.js.
34+
const { title } = await result;
35+
36+
// Update these values with the expected values from
37+
// the article.
38+
assert.equal(title, 'Coal\'s big US stronghold is losing steam, even as Trump aims for a revival');
39+
});
40+
41+
it('returns the author', async () => {
42+
// To pass this test, fill out the author selector
43+
// in ./src/extractors/custom/www.cnbc.com/index.js.
44+
const { author } = await result;
45+
46+
// Update these values with the expected values from
47+
// the article.
48+
assert.equal(author, 'Tom DiChristopher');
49+
});
50+
51+
it('returns the date_published', async () => {
52+
// To pass this test, fill out the date_published selector
53+
// in ./src/extractors/custom/www.cnbc.com/index.js.
54+
const { date_published } = await result;
55+
56+
// Update these values with the expected values from
57+
// the article.
58+
assert.equal(date_published, '2016-12-20T15:32:57.000Z');
59+
});
60+
61+
it('returns the lead_image_url', async () => {
62+
// To pass this test, fill out the lead_image_url selector
63+
// in ./src/extractors/custom/www.cnbc.com/index.js.
64+
const { lead_image_url } = await result;
65+
66+
// Update these values with the expected values from
67+
// the article.
68+
assert.equal(lead_image_url, 'http://fm.cnbc.com/applications/cnbc.com/resources/img/editorial/2016/12/19/104176162-GettyImages-161350847.1910x1000.jpg');
69+
});
70+
71+
it('returns the content', async () => {
72+
// To pass this test, fill out the content selector
73+
// in ./src/extractors/custom/www.cnbc.com/index.js.
74+
// You may also want to make use of the clean and transform
75+
// options.
76+
const { content } = await result;
77+
78+
const $ = cheerio.load(content || '');
79+
80+
const first13 = excerptContent($('*').first().text(), 13);
81+
82+
// Update these values with the expected values from
83+
// the article.
84+
assert.equal(first13, 'Brian Brainerd | The Denver Post | Getty Images The U.S. Mountain States');
85+
});
86+
});
87+
});

0 commit comments

Comments
 (0)