Skip to content

Commit 994a3d2

Browse files
Apply suggestions from code review
Co-authored-by: Davis Vaughan <[email protected]>
1 parent 8ce6a47 commit 994a3d2

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

crates/ark/src/interface.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -584,18 +584,18 @@ impl RMain {
584584

585585
// In the future we'll also send browser information, see
586586
// https://github.com/posit-dev/positron/issues/3001. Currently this is
587-
// a push model where we send the console scopes at each round. In the
587+
// a push model where we send the console inputs at each round. In the
588588
// future, a pull model would be better, this way the LSP can manage a
589-
// cache of scopes and we don't need to retraverse the environments as
590-
// often. We'd still push a `DidChangeConsoleScopes` notification from
589+
// cache of inputs and we don't need to retraverse the environments as
590+
// often. We'd still push a `DidChangeConsoleInputs` notification from
591591
// here, but only containing high-level information such as `search()`
592592
// contents and `ls(rho)`.
593593
if !info.browser && !info.incomplete && !info.input_request {
594594
match console_inputs() {
595595
Ok(inputs) => {
596596
self.send_lsp(LspEvent::DidChangeConsoleInputs(inputs));
597597
},
598-
Err(err) => log::error!("Can't retrieve console scopes: {err:?}"),
598+
Err(err) => log::error!("Can't retrieve console inputs: {err:?}"),
599599
}
600600
}
601601

crates/ark/src/lsp/state.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ pub struct WorldState {
2020
pub workspace: Arc<Mutex<Workspace>>,
2121

2222
/// The scopes for the console. This currently contains a list (outer `Vec`)
23-
/// of names (inner `Vec`) of the environments on the search path, starting
23+
/// of names (inner `Vec`) within the environments on the search path, starting
2424
/// from the global environment and ending with the base package. Eventually
2525
/// this might also be populated with the scope for the current environment
2626
/// in debug sessions (not implemented yet).

0 commit comments

Comments
 (0)